Silverfish/proton-bridge
1
0
Fork 1
mirror of https://github.com/ProtonMail/proton-bridge.git synced 2025-12-15 14:56:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Other: Bump go-smtp version to fix race condition

Browse Source 
There was a race condition internal to the go-smtp library.
In order to fix it, a version bump was necessary.
However, this significantly changed the library interface.
This commit is contained in:
James Houlahan
2022-10-21 11:07:53 +02:00
parent 974735d415
commit 0f125196a6
13 changed files with 210 additions and 316 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/features/smtp/init.feature
View File

@ -39,13 +39,23 @@ Feature: SMTP initiation
Then it fails with error "Missing RCPT TO command"
Scenario: Send with empty FROM
When SMTP client "1" sends MAIL FROM "<>"
Then it fails with error "invalid return path"
When SMTP client "1" sends the following message from "<>" to "bridgetest@protonmail.com":
"""
To: Internal Bridge <bridgetest@protonmail.com>
this should fail
"""
Then it fails
Scenario: Send with empty TO
When SMTP client "1" sends MAIL FROM "<user@pm.me>"
Then it succeeds
When SMTP client "1" sends RCPT TO "<>"
Then it succeeds
When SMTP client "1" sends DATA:
"""
Subject: test
"""
Then it fails with error "invalid recipient"
Scenario: Allow BODY parameter of MAIL FROM command
@ -53,5 +63,10 @@ Feature: SMTP initiation
Then it succeeds
Scenario: FROM not owned by user
When SMTP client "1" sends MAIL FROM "<user@pm.test>"
Then it fails with error "invalid return path"
When SMTP client "1" sends the following message from "other@pm.me" to "bridgetest@protonmail.com":
"""
From: Bridge Test <user@pm.me>
To: Internal Bridge <bridgetest@protonmail.com>
this should fail
"""