From 7cb9d62f0c129801f56b3bd9892b77a45a0501be Mon Sep 17 00:00:00 2001 From: James Houlahan Date: Tue, 22 Nov 2022 14:04:13 +0100 Subject: [PATCH] Other: Don't forward stdin/stdout/stderr --- pkg/restarter/restarter.go | 5 ----- pkg/restarter/start_default.go | 5 +++++ pkg/restarter/start_windows.go | 3 +++ 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/pkg/restarter/restarter.go b/pkg/restarter/restarter.go index 788ed78b..e56c3f1a 100644 --- a/pkg/restarter/restarter.go +++ b/pkg/restarter/restarter.go @@ -92,13 +92,8 @@ func (restarter *Restarter) Restart() { return } - cmd.Stdin = os.Stdin - cmd.Stdout = os.Stdout - cmd.Stderr = os.Stderr cmd.Env = getEnvList(env) - l.Warn("Restarting") - if err := run(cmd); err != nil { l.WithError(err).Error("Failed to restart") } diff --git a/pkg/restarter/start_default.go b/pkg/restarter/start_default.go index 47aca556..d0988a32 100644 --- a/pkg/restarter/start_default.go +++ b/pkg/restarter/start_default.go @@ -23,6 +23,8 @@ package restarter import ( "os/exec" "syscall" + + "github.com/sirupsen/logrus" ) func run(cmd *exec.Cmd) error { @@ -31,5 +33,8 @@ func run(cmd *exec.Cmd) error { Setpgid: true, Pgid: 0, } + + logrus.WithField("cmd", cmd).Info("Starting new process") + return cmd.Start() } diff --git a/pkg/restarter/start_windows.go b/pkg/restarter/start_windows.go index 4d15fc43..129ca32f 100644 --- a/pkg/restarter/start_windows.go +++ b/pkg/restarter/start_windows.go @@ -30,5 +30,8 @@ func run(cmd *exec.Cmd) error { cmd.SysProcAttr = &syscall.SysProcAttr{ CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP, } + + logrus.WithField("cmd", cmd).Info("Starting new process") + return cmd.Start() }