From 7df2d70dbff8c591f072a42aa0dde026509f64ea Mon Sep 17 00:00:00 2001
From: James Houlahan <james.houlahan@proton.ch>
Date: Mon, 24 Oct 2022 16:48:49 +0200
Subject: [PATCH] Other: Fix race condition in bridge mock updater

We need to protect the latest version info by a lock.
---
 internal/bridge/mocks.go | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/internal/bridge/mocks.go b/internal/bridge/mocks.go
index e985ffbf..ea0ddbfa 100644
--- a/internal/bridge/mocks.go
+++ b/internal/bridge/mocks.go
@@ -4,6 +4,7 @@ import (
 	"net/http"
 	"net/url"
 	"os"
+	"sync"
 	"testing"
 
 	"github.com/Masterminds/semver/v3"
@@ -92,6 +93,7 @@ func (provider *TestLocationsProvider) UserCache() string {
 
 type TestUpdater struct {
 	latest updater.VersionInfo
+	lock   sync.RWMutex
 }
 
 func NewTestUpdater(version, minAuto *semver.Version) *TestUpdater {
@@ -106,6 +108,9 @@ func NewTestUpdater(version, minAuto *semver.Version) *TestUpdater {
 }
 
 func (testUpdater *TestUpdater) SetLatestVersion(version, minAuto *semver.Version) {
+	testUpdater.lock.Lock()
+	defer testUpdater.lock.Unlock()
+
 	testUpdater.latest = updater.VersionInfo{
 		Version: version,
 		MinAuto: minAuto,
@@ -115,6 +120,9 @@ func (testUpdater *TestUpdater) SetLatestVersion(version, minAuto *semver.Versio
 }
 
 func (testUpdater *TestUpdater) GetVersionInfo(downloader updater.Downloader, channel updater.Channel) (updater.VersionInfo, error) {
+	testUpdater.lock.RLock()
+	defer testUpdater.lock.RUnlock()
+
 	return testUpdater.latest, nil
 }