From a00b3cdb92af7b251f87fe4f188f17b4adfb854e Mon Sep 17 00:00:00 2001 From: Leander Beernaert Date: Thu, 9 Nov 2023 13:22:39 +0100 Subject: [PATCH] fix(GODT-3054): Delete draft create from reply If an IMAP client creates a new message as a reply/forward from an existing draft, that draft will be deleted once the message has been sent. Other than not being the correct behavior, the original reason for which this line of code was added (carried over from v2), seems to be no longer necessary as in all tests, the message is correctly removed from the drafts folder after sent. --- internal/services/smtp/smtp.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/services/smtp/smtp.go b/internal/services/smtp/smtp.go index cf509914..1e9d8972 100644 --- a/internal/services/smtp/smtp.go +++ b/internal/services/smtp/smtp.go @@ -292,8 +292,6 @@ func getParentID( for _, metadata := range metadata { if !metadata.IsDraft() { parentID = metadata.ID - } else if err := client.DeleteMessage(ctx, metadata.ID); err != nil { - return "", fmt.Errorf("failed to delete message: %w", err) } } }