chore: remove export loop ref and loop-scope assignments (changed with go 1.22)

.golangci.yml

@@ -87,7 +87,6 @@ linters:
     - asciicheck        # Simple linter to check that your code does not contain non-ASCII identifiers [fast: true, auto-fix: false]
     - durationcheck     # check for two durations multiplied together [fast: false, auto-fix: false]
     - exhaustive        # check exhaustiveness of enum switch statements [fast: false, auto-fix: false]
-    - exportloopref     # checks for pointers to enclosing loop variables [fast: false, auto-fix: false]
     - copyloopvar       # detects places where loop variables are copied.
     - forcetypeassert   # finds forced type assertions [fast: true, auto-fix: false]
     - godot             # Check if comments end in a period [fast: true, auto-fix: true]

internal/services/smtp/smtp_packages_test.go

@@ -241,7 +241,6 @@ func TestCreateSendReq_PGPMIMEScheme(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test // Avoid using range scope test inside function literal.
 		t.Run(test.name, func(t *testing.T) { checkCreateSendReq(t, test, kr) })
 	}
 }
@@ -442,7 +441,6 @@ func TestCreateSendReq_ClearMIMEScheme(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test // Avoid using range scope test inside function literal.
 		t.Run(test.name, func(t *testing.T) { checkCreateSendReq(t, test, kr) })
 	}
 }
@@ -643,7 +641,6 @@ func TestCreateSendReq_InternalScheme(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test // Avoid using range scope test inside function literal.
 		t.Run(test.name, func(t *testing.T) { checkCreateSendReq(t, test, kr) })
 	}
 }
@@ -849,7 +846,6 @@ func TestCreateSendReq_PGPInlineScheme(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test // Avoid using range scope test inside function literal.
 		t.Run(test.name, func(t *testing.T) { checkCreateSendReq(t, test, kr) })
 	}
 }
@@ -1065,7 +1061,6 @@ func TestCreateSendReq_ClearScheme(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test // Avoid using range scope test inside function literal.
 		t.Run(test.name, func(t *testing.T) { checkCreateSendReq(t, test, kr) })
 	}
 }

internal/services/smtp/smtp_prefs_test.go

@@ -405,8 +405,6 @@ func TestPreferencesBuilder(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test // Avoid using range scope test inside function literal.
-
 		t.Run(test.name, func(t *testing.T) {
 			b := &sendPrefsBuilder{}
 

internal/useragent/useragent_test.go

@@ -75,8 +75,6 @@ func TestUserAgent(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
-
 		t.Run(test.want, func(t *testing.T) {
 			ua := New()