Silverfish/proton-bridge
1
0
Fork 1
mirror of https://github.com/ProtonMail/proton-bridge.git synced 2025-12-29 13:06:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: better confirmer result locking

Browse Source
This commit is contained in:
James Houlahan
2020-07-24 14:50:08 +02:00
parent d66bcc4b63
commit b12ef1327c
2 changed files with 25 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/confirmer/confirmer_test.go
View File

@ -66,7 +66,7 @@ func TestConfirmerTimeout(t *testing.T) {
assert.Error(t, err)
}
func TestConfirmerMultipleRequestCalls(t *testing.T) {
func TestConfirmerMultipleResultCalls(t *testing.T) {
c := New()
req := c.NewRequest(1 * time.Second)
@ -83,6 +83,25 @@ func TestConfirmerMultipleRequestCalls(t *testing.T) {
assert.Error(t, errAgain)
}
func TestConfirmerMultipleSimultaneousResultCalls(t *testing.T) {
c := New()
req := c.NewRequest(1 * time.Second)
go func() {
time.Sleep(1 * time.Second)
assert.NoError(t, c.SetResult(req.ID(), true))
}()
// We just check that nothing panics. We can't know which Result() will get the result though.
go func() { _, _ = req.Result() }()
go func() { _, _ = req.Result() }()
go func() { _, _ = req.Result() }()
_, _ = req.Result()
}
func TestConfirmerMultipleSetResultCalls(t *testing.T) {
c := New()