Silverfish/proton-bridge
1
0
Fork 1
mirror of https://github.com/ProtonMail/proton-bridge.git synced 2025-12-20 09:06:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test: add comment for why tests are disabled

Browse Source
This commit is contained in:
James Houlahan
2020-04-29 13:51:36 +02:00
committed by Michal Horejsek
parent 2db1b113e0
commit df3a9ea19e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/pmapi/dialer_pinning_test.go
View File

@ -115,14 +115,16 @@ func _TestTLSPinInvalid(t *testing.T) { // nolint[unused]
Equals(t, 1, *called) Equals(t, 1, *called)
} }
func TestTLSSignedCertWrongPublicKey(t *testing.T) { // nolint[unused] // The tests below should pass but cannot run in CI due to proxy issues.
func _TestTLSSignedCertWrongPublicKey(t *testing.T) { // nolint[unused]
cm := newTestClientManager(testLiveConfig) cm := newTestClientManager(testLiveConfig)
_, dialer := createAndSetPinningDialer(cm) _, dialer := createAndSetPinningDialer(cm)
_, err := dialer.DialTLS("tcp", "rsa4096.badssl.com:443") _, err := dialer.DialTLS("tcp", "rsa4096.badssl.com:443")
assert.Error(t, err, "expected dial to fail because of wrong public key") assert.Error(t, err, "expected dial to fail because of wrong public key")
} }
func TestTLSSignedCertTrustedPublicKey(t *testing.T) { // nolint[unused] func _TestTLSSignedCertTrustedPublicKey(t *testing.T) { // nolint[unused]
cm := newTestClientManager(testLiveConfig) cm := newTestClientManager(testLiveConfig)
_, dialer := createAndSetPinningDialer(cm) _, dialer := createAndSetPinningDialer(cm)
dialer.pinChecker.trustedPins = append(dialer.pinChecker.trustedPins, `pin-sha256="W8/42Z0ffufwnHIOSndT+eVzBJSC0E8uTIC8O6mEliQ="`) dialer.pinChecker.trustedPins = append(dialer.pinChecker.trustedPins, `pin-sha256="W8/42Z0ffufwnHIOSndT+eVzBJSC0E8uTIC8O6mEliQ="`)
@ -130,7 +132,7 @@ func TestTLSSignedCertTrustedPublicKey(t *testing.T) { // nolint[unused]
assert.NoError(t, err, "expected dial to succeed because public key is known and cert is signed by CA") assert.NoError(t, err, "expected dial to succeed because public key is known and cert is signed by CA")
} }
func TestTLSSelfSignedCertTrustedPublicKey(t *testing.T) { // nolint[unused] func _TestTLSSelfSignedCertTrustedPublicKey(t *testing.T) { // nolint[unused]
cm := newTestClientManager(testLiveConfig) cm := newTestClientManager(testLiveConfig)
_, dialer := createAndSetPinningDialer(cm) _, dialer := createAndSetPinningDialer(cm)
dialer.pinChecker.trustedPins = append(dialer.pinChecker.trustedPins, `pin-sha256="9SLklscvzMYj8f+52lp5ze/hY0CFHyLSPQzSpYYIBm8="`) dialer.pinChecker.trustedPins = append(dialer.pinChecker.trustedPins, `pin-sha256="9SLklscvzMYj8f+52lp5ze/hY0CFHyLSPQzSpYYIBm8="`)