diff --git a/Changelog.md b/Changelog.md index b5c97acf..852a7275 100644 --- a/Changelog.md +++ b/Changelog.md @@ -4,6 +4,11 @@ Changelog [format](http://keepachangelog.com/en/1.0.0/) ## Unreleased +## [Bridge 1.4.2] Forth + +### Changed +* GODT-761 Use label.Path instead of Name to partially support subfolders for webapp beta release. + ## [IE 1.1.1] Danube (beta 2020-09-xx) [Bridge 1.4.1] Forth (beta 2020-09-xx) ### Fixed diff --git a/internal/bridge/credits.go b/internal/bridge/credits.go index 15d6e6a2..12f61bc5 100644 --- a/internal/bridge/credits.go +++ b/internal/bridge/credits.go @@ -15,8 +15,8 @@ // You should have received a copy of the GNU General Public License // along with ProtonMail Bridge. If not, see . -// Code generated by ./credits.sh at Wed Sep 16 16:48:58 CEST 2020. DO NOT EDIT. +// Code generated by ./credits.sh at Tue Sep 29 14:56:25 CEST 2020. DO NOT EDIT. package bridge -const Credits = "github.com/0xAX/notificator;github.com/ProtonMail/bcrypt;github.com/ProtonMail/crypto;github.com/ProtonMail/docker-credential-helpers;github.com/ProtonMail/go-appdir;github.com/ProtonMail/go-apple-mobileconfig;github.com/ProtonMail/go-autostart;github.com/ProtonMail/go-imap;github.com/ProtonMail/go-imap-id;github.com/ProtonMail/go-smtp;github.com/ProtonMail/go-vcard;github.com/ProtonMail/gopenpgp/v2;github.com/PuerkitoBio/goquery;github.com/abiosoft/ishell;github.com/abiosoft/readline;github.com/allan-simon/go-singleinstance;github.com/certifi/gocertifi;github.com/chzyer/logex;github.com/chzyer/test;github.com/cucumber/godog;github.com/docker/docker-credential-helpers;github.com/emersion/go-imap;github.com/emersion/go-imap-appendlimit;github.com/emersion/go-imap-idle;github.com/emersion/go-imap-move;github.com/emersion/go-imap-quota;github.com/emersion/go-imap-specialuse;github.com/emersion/go-imap-unselect;github.com/emersion/go-mbox;github.com/emersion/go-message;github.com/emersion/go-sasl;github.com/emersion/go-smtp;github.com/emersion/go-textwrapper;github.com/emersion/go-vcard;github.com/fatih/color;github.com/flynn-archive/go-shlex;github.com/getsentry/raven-go;github.com/go-resty/resty/v2;github.com/golang/mock;github.com/google/go-cmp;github.com/google/uuid;github.com/gopherjs/gopherjs;github.com/hashicorp/go-multierror;github.com/jameskeane/bcrypt;github.com/jaytaylor/html2text;github.com/kardianos/osext;github.com/keybase/go-keychain;github.com/logrusorgru/aurora;github.com/mattn/go-runewidth;github.com/miekg/dns;github.com/myesui/uuid;github.com/nsf/jsondiff;github.com/olekukonko/tablewriter;github.com/pkg/errors;github.com/sirupsen/logrus;github.com/skratchdot/open-golang;github.com/ssor/bom;github.com/stretchr/testify;github.com/therecipe/qt;github.com/twinj/uuid;github.com/urfave/cli;go.etcd.io/bbolt;golang.org/x/crypto;golang.org/x/net;golang.org/x/text;gopkg.in/stretchr/testify.v1;;Font Awesome 4.7.0;;Qt 5.13 by Qt group;" +const Credits = "github.com/0xAX/notificator;github.com/Masterminds/semver/v3;github.com/ProtonMail/bcrypt;github.com/ProtonMail/crypto;github.com/ProtonMail/docker-credential-helpers;github.com/ProtonMail/go-appdir;github.com/ProtonMail/go-apple-mobileconfig;github.com/ProtonMail/go-autostart;github.com/ProtonMail/go-imap;github.com/ProtonMail/go-imap-id;github.com/ProtonMail/go-smtp;github.com/ProtonMail/go-vcard;github.com/ProtonMail/gopenpgp/v2;github.com/ProtonMail/mbox;github.com/PuerkitoBio/goquery;github.com/abiosoft/ishell;github.com/abiosoft/readline;github.com/allan-simon/go-singleinstance;github.com/certifi/gocertifi;github.com/chzyer/logex;github.com/chzyer/test;github.com/cucumber/godog;github.com/docker/docker-credential-helpers;github.com/emersion/go-imap;github.com/emersion/go-imap-appendlimit;github.com/emersion/go-imap-idle;github.com/emersion/go-imap-move;github.com/emersion/go-imap-quota;github.com/emersion/go-imap-specialuse;github.com/emersion/go-imap-unselect;github.com/emersion/go-mbox;github.com/emersion/go-message;github.com/emersion/go-sasl;github.com/emersion/go-smtp;github.com/emersion/go-textwrapper;github.com/emersion/go-vcard;github.com/fatih/color;github.com/flynn-archive/go-shlex;github.com/getsentry/raven-go;github.com/go-resty/resty/v2;github.com/golang/mock;github.com/google/go-cmp;github.com/google/uuid;github.com/gopherjs/gopherjs;github.com/hashicorp/go-multierror;github.com/jameskeane/bcrypt;github.com/jaytaylor/html2text;github.com/kardianos/osext;github.com/keybase/go-keychain;github.com/logrusorgru/aurora;github.com/mattn/go-runewidth;github.com/miekg/dns;github.com/myesui/uuid;github.com/nsf/jsondiff;github.com/olekukonko/tablewriter;github.com/pkg/errors;github.com/sirupsen/logrus;github.com/skratchdot/open-golang;github.com/ssor/bom;github.com/stretchr/testify;github.com/therecipe/qt;github.com/twinj/uuid;github.com/urfave/cli;go.etcd.io/bbolt;golang.org/x/crypto;golang.org/x/net;golang.org/x/text;gopkg.in/stretchr/testify.v1;;Font Awesome 4.7.0;;Qt 5.13 by Qt group;" diff --git a/internal/importexport/credits.go b/internal/importexport/credits.go index a8d79c8d..1b05aead 100644 --- a/internal/importexport/credits.go +++ b/internal/importexport/credits.go @@ -15,8 +15,8 @@ // You should have received a copy of the GNU General Public License // along with ProtonMail Bridge. If not, see . -// Code generated by ./credits.sh at Wed Sep 23 01:34:10 PM CEST 2020. DO NOT EDIT. +// Code generated by ./credits.sh at Tue Sep 29 14:56:25 CEST 2020. DO NOT EDIT. package importexport -const Credits = "github.com/0xAX/notificator;github.com/abiosoft/ishell;github.com/abiosoft/readline;github.com/allan-simon/go-singleinstance;github.com/certifi/gocertifi;github.com/chzyer/logex;github.com/chzyer/test;github.com/cucumber/godog;github.com/docker/docker-credential-helpers;github.com/emersion/go-imap;github.com/emersion/go-imap-appendlimit;github.com/emersion/go-imap-idle;github.com/emersion/go-imap-move;github.com/emersion/go-imap-quota;github.com/emersion/go-imap-specialuse;github.com/emersion/go-imap-unselect;github.com/emersion/go-mbox;github.com/emersion/go-message;github.com/emersion/go-sasl;github.com/emersion/go-smtp;github.com/emersion/go-textwrapper;github.com/emersion/go-vcard;github.com/fatih/color;github.com/flynn-archive/go-shlex;github.com/getsentry/raven-go;github.com/golang/mock;github.com/google/go-cmp;github.com/google/uuid;github.com/gopherjs/gopherjs;github.com/go-resty/resty/v2;github.com/hashicorp/go-multierror;github.com/jameskeane/bcrypt;github.com/jaytaylor/html2text;github.com/kardianos/osext;github.com/keybase/go-keychain;github.com/logrusorgru/aurora;github.com/Masterminds/semver/v3;github.com/mattn/go-runewidth;github.com/miekg/dns;github.com/myesui/uuid;github.com/nsf/jsondiff;github.com/olekukonko/tablewriter;github.com/pkg/errors;github.com/ProtonMail/bcrypt;github.com/ProtonMail/crypto;github.com/ProtonMail/docker-credential-helpers;github.com/ProtonMail/go-appdir;github.com/ProtonMail/go-apple-mobileconfig;github.com/ProtonMail/go-autostart;github.com/ProtonMail/go-imap;github.com/ProtonMail/go-imap-id;github.com/ProtonMail/gopenpgp/v2;github.com/ProtonMail/go-smtp;github.com/ProtonMail/go-vcard;github.com/ProtonMail/mbox;github.com/PuerkitoBio/goquery;github.com/sirupsen/logrus;github.com/skratchdot/open-golang;github.com/ssor/bom;github.com/stretchr/testify;github.com/therecipe/qt;github.com/twinj/uuid;github.com/urfave/cli;go.etcd.io/bbolt;golang.org/x/crypto;golang.org/x/net;golang.org/x/text;gopkg.in/stretchr/testify.v1;;Font Awesome 4.7.0;;Qt 5.13 by Qt group;" +const Credits = "github.com/0xAX/notificator;github.com/Masterminds/semver/v3;github.com/ProtonMail/bcrypt;github.com/ProtonMail/crypto;github.com/ProtonMail/docker-credential-helpers;github.com/ProtonMail/go-appdir;github.com/ProtonMail/go-apple-mobileconfig;github.com/ProtonMail/go-autostart;github.com/ProtonMail/go-imap;github.com/ProtonMail/go-imap-id;github.com/ProtonMail/go-smtp;github.com/ProtonMail/go-vcard;github.com/ProtonMail/gopenpgp/v2;github.com/ProtonMail/mbox;github.com/PuerkitoBio/goquery;github.com/abiosoft/ishell;github.com/abiosoft/readline;github.com/allan-simon/go-singleinstance;github.com/certifi/gocertifi;github.com/chzyer/logex;github.com/chzyer/test;github.com/cucumber/godog;github.com/docker/docker-credential-helpers;github.com/emersion/go-imap;github.com/emersion/go-imap-appendlimit;github.com/emersion/go-imap-idle;github.com/emersion/go-imap-move;github.com/emersion/go-imap-quota;github.com/emersion/go-imap-specialuse;github.com/emersion/go-imap-unselect;github.com/emersion/go-mbox;github.com/emersion/go-message;github.com/emersion/go-sasl;github.com/emersion/go-smtp;github.com/emersion/go-textwrapper;github.com/emersion/go-vcard;github.com/fatih/color;github.com/flynn-archive/go-shlex;github.com/getsentry/raven-go;github.com/go-resty/resty/v2;github.com/golang/mock;github.com/google/go-cmp;github.com/google/uuid;github.com/gopherjs/gopherjs;github.com/hashicorp/go-multierror;github.com/jameskeane/bcrypt;github.com/jaytaylor/html2text;github.com/kardianos/osext;github.com/keybase/go-keychain;github.com/logrusorgru/aurora;github.com/mattn/go-runewidth;github.com/miekg/dns;github.com/myesui/uuid;github.com/nsf/jsondiff;github.com/olekukonko/tablewriter;github.com/pkg/errors;github.com/sirupsen/logrus;github.com/skratchdot/open-golang;github.com/ssor/bom;github.com/stretchr/testify;github.com/therecipe/qt;github.com/twinj/uuid;github.com/urfave/cli;go.etcd.io/bbolt;golang.org/x/crypto;golang.org/x/net;golang.org/x/text;gopkg.in/stretchr/testify.v1;;Font Awesome 4.7.0;;Qt 5.13 by Qt group;" diff --git a/internal/store/address.go b/internal/store/address.go index d890742b..65e1fb07 100644 --- a/internal/store/address.go +++ b/internal/store/address.go @@ -69,7 +69,7 @@ func (storeAddress *Address) init(foldersAndLabels []*pmapi.Label) (err error) { prefix := getLabelPrefix(label) var mailbox *Mailbox - if mailbox, err = txNewMailbox(tx, storeAddress, label.ID, prefix, label.Name, label.Color); err != nil { + if mailbox, err = txNewMailbox(tx, storeAddress, label.ID, prefix, label.Path, label.Color); err != nil { storeAddress.log. WithError(err). WithField("labelID", label.ID). diff --git a/internal/store/address_mailbox.go b/internal/store/address_mailbox.go index dfa4a78e..33efcdf7 100644 --- a/internal/store/address_mailbox.go +++ b/internal/store/address_mailbox.go @@ -73,14 +73,14 @@ func (storeAddress *Address) createOrUpdateMailboxEvent(label *pmapi.Label) erro prefix := getLabelPrefix(label) mailbox, ok := storeAddress.mailboxes[label.ID] if !ok { - mailbox, err := newMailbox(storeAddress, label.ID, prefix, label.Name, label.Color) + mailbox, err := newMailbox(storeAddress, label.ID, prefix, label.Path, label.Color) if err != nil { return err } storeAddress.mailboxes[label.ID] = mailbox mailbox.store.imapMailboxCreated(storeAddress.address, mailbox.labelName) } else { - mailbox.labelName = prefix + label.Name + mailbox.labelName = prefix + label.Path mailbox.color = label.Color } return nil diff --git a/internal/store/mailbox_counts.go b/internal/store/mailbox_counts.go index 3674a1d8..4fd3a636 100644 --- a/internal/store/mailbox_counts.go +++ b/internal/store/mailbox_counts.go @@ -125,6 +125,7 @@ func (mc *mailboxCounts) getPMLabel() *pmapi.Label { return &pmapi.Label{ ID: mc.LabelID, Name: mc.LabelName, + Path: mc.LabelName, Color: mc.Color, Order: mc.Order, Type: pmapi.LabelTypeMailbox, @@ -158,7 +159,7 @@ func (store *Store) createOrUpdateMailboxCountsBuckets(labels []*pmapi.Label) er } // Update mailbox info, but dont change on-API-counts. - mailbox.LabelName = label.Name + mailbox.LabelName = label.Path mailbox.Color = label.Color mailbox.Order = label.Order mailbox.IsFolder = label.Exclusive == 1 diff --git a/pkg/pmapi/labels.go b/pkg/pmapi/labels.go index cc970740..9e0c7808 100644 --- a/pkg/pmapi/labels.go +++ b/pkg/pmapi/labels.go @@ -80,6 +80,7 @@ const ( type Label struct { ID string Name string + Path string Color string Order int `json:",omitempty"` Display int // Not used for now, leave it empty. diff --git a/test/fakeapi/controller_control.go b/test/fakeapi/controller_control.go index 0bf2cd21..c8d1db40 100644 --- a/test/fakeapi/controller_control.go +++ b/test/fakeapi/controller_control.go @@ -83,6 +83,9 @@ func (ctl *Controller) AddUserLabel(username string, label *pmapi.Label) error { } label.ID = ctl.labelIDGenerator.next(prefix) label.Name = labelName + if label.Path == "" { + label.Path = label.Name + } ctl.labelsByUsername[username] = append(ctl.labelsByUsername[username], label) ctl.resetUsers() return nil diff --git a/test/fakeapi/labels.go b/test/fakeapi/labels.go index 24be7e5a..8d88c009 100644 --- a/test/fakeapi/labels.go +++ b/test/fakeapi/labels.go @@ -53,6 +53,9 @@ func (api *FakePMAPI) CreateLabel(label *pmapi.Label) (*pmapi.Label, error) { prefix = "folder" } label.ID = api.controller.labelIDGenerator.next(prefix) + if label.Path == "" { + label.Path = label.Name + } api.labels = append(api.labels, label) api.addEventLabel(pmapi.EventCreate, label) return label, nil @@ -67,6 +70,9 @@ func (api *FakePMAPI) UpdateLabel(label *pmapi.Label) (*pmapi.Label, error) { // Request doesn't have to include all properties and these have to stay the same. label.Type = existingLabel.Type label.Exclusive = existingLabel.Exclusive + if label.Path == "" { + label.Path = label.Name + } api.labels[idx] = label api.addEventLabel(pmapi.EventUpdate, label) return label, nil diff --git a/test/features/bridge/imap/mailbox/list.feature b/test/features/bridge/imap/mailbox/list.feature index 0fa0989e..e8848f1f 100644 --- a/test/features/bridge/imap/mailbox/list.feature +++ b/test/features/bridge/imap/mailbox/list.feature @@ -1,11 +1,11 @@ Feature: IMAP list mailboxes Background: Given there is connected user "user" - And there is "user" with mailbox "Folders/mbox1" - And there is "user" with mailbox "Labels/mbox2" - And there is IMAP client logged in as "user" Scenario: List mailboxes + Given there is "user" with mailbox "Folders/mbox1" + And there is "user" with mailbox "Labels/mbox2" + And there is IMAP client logged in as "user" When IMAP client lists mailboxes Then IMAP response contains "INBOX" Then IMAP response contains "Sent" @@ -14,3 +14,16 @@ Feature: IMAP list mailboxes Then IMAP response contains "All Mail" Then IMAP response contains "Folders/mbox1" Then IMAP response contains "Labels/mbox2" + + @ignore-live + Scenario: List mailboxes with subfolders + # Escaped slash in the name contains slash in the name. + # Not-escaped slash in the name means tree structure. + # We keep escaping in an IMAP communication so each mailbox is unique and + # both mailboxes are accessible. The slash is visible in the IMAP client. + Given there is "user" with mailbox "Folders/a\/b" + And there is "user" with mailbox "Folders/a/b" + And there is IMAP client logged in as "user" + When IMAP client lists mailboxes + Then IMAP response contains "Folders/a\/b" + Then IMAP response contains "Folders/a/b" diff --git a/test/features/imap/message/delete_from_trash.feature b/test/features/bridge/imap/message/delete_from_trash.feature similarity index 100% rename from test/features/imap/message/delete_from_trash.feature rename to test/features/bridge/imap/message/delete_from_trash.feature diff --git a/test/features/imap/message/move_without_support.feature b/test/features/bridge/imap/message/move_without_support.feature similarity index 100% rename from test/features/imap/message/move_without_support.feature rename to test/features/bridge/imap/message/move_without_support.feature