Bridge Golden-Gate 1.5.7

Fixed
• Fixed sending error caused by inconsistent use of upper and lower case in sender’s email address

Changelog.md

@@ -2,10 +2,15 @@
 
 Changelog [format](http://keepachangelog.com/en/1.0.0/)
 
+## [Bridge 1.5.7] Golden Gate
+
+### Fixed
+CSB-331 Fix sending error due to mixed case in sender address.
+
 ## [Bridge 1.5.6] Golden Gate
 
 ### Added
-* GODT-797 EXPUNGE waits for APPEND to prevent data loss when Outlook moves from Spam to Inbox
+* GODT-797 EXPUNGE waits for APPEND to prevent data loss when Outlook moves from Spam to Inbox.
 
 
 ## [Bridge 1.5.5] Golden Gate

Makefile

@@ -10,7 +10,7 @@ TARGET_OS?=${GOOS}
 .PHONY: build build-ie build-nogui build-ie-nogui check-has-go
 
 # Keep version hardcoded so app build works also without Git repository.
-BRIDGE_APP_VERSION?=1.5.6-git
+BRIDGE_APP_VERSION?=1.5.7-git
 IE_APP_VERSION?=1.2.3-git
 APP_VERSION:=${BRIDGE_APP_VERSION}
 SRC_ICO:=logo.ico

internal/bridge/release_notes.go

@@ -15,18 +15,12 @@
 // You should have received a copy of the GNU General Public License
 // along with ProtonMail Bridge.  If not, see <https://www.gnu.org/licenses/>.
 
-// Code generated by ./release-notes.sh at 'Thu Jan 14 04:51:03 PM CET 2021'. DO NOT EDIT.
+// Code generated by ./release-notes.sh at 'Fri Jan 22 11:01:06 AM CET 2021'. DO NOT EDIT.
 
 package bridge
 
-const ReleaseNotes = `• Improvements to message parsing
+const ReleaseNotes = `
-• Better error handling
 `
 
-const ReleaseFixedBugs = `• Message corruption - rare cases of overly long headers
+const ReleaseFixedBugs = `• Fixed sending error caused by inconsistent use of upper and lower case in sender’s email address
-• AppleMail crashes (related to timestamps)
-• Sending messages from aliases in combined inbox mode
-• Fedora font issues
-
-For more detailed summary of the changes see https://github.com/ProtonMail/proton-bridge/blob/master/Changelog.md
 `

internal/smtp/user.go

@@ -251,6 +251,8 @@ func (su *smtpUser) Send(returnPath string, to []string, messageReader io.Reader
 		return
 	}
 
+	message.Sender.Address = pmapi.ConstructAddress(message.Sender.Address, addr.Email)
+
 	kr, err := su.client().KeyRingForAddressID(addr.ID)
 	if err != nil {
 		return

release-notes/bugs-bridge.txt

@@ -1,8 +1 @@
-• Message corruption - rare cases of overly long headers
+• Fixed sending error caused by inconsistent use of upper and lower case in sender’s email address
-• AppleMail crashes (related to timestamps)
-• Sending messages from aliases in combined inbox mode
-• Fedora font issues
-
-For more detailed summary of the changes see https://github.com/ProtonMail/proton-bridge/blob/master/Changelog.md
-
-

release-notes/notes-bridge.txt

@@ -1,2 +0,0 @@
-• Improvements to message parsing
-• Better error handling

test/features/bridge/smtp/send/mixed_case.feature

@@ -0,0 +1,38 @@
+Feature: SMTP sending with mixed case address
+  Background:
+    Given there is connected user "user"
+    And there is SMTP client logged in as "user"
+
+  Scenario: Mixed sender case in sender address
+    When SMTP client sends message
+      """
+      From: Bridge Test <[userAddress|capitalize]>
+      To: Internal Bridge <bridgetest@protonmail.com>
+
+      hello
+
+      """
+    Then SMTP response is "OK"
+    And mailbox "Sent" for "user" has messages
+      | from          | to                        | subject |
+      | [userAddress] | bridgetest@protonmail.com |         |
+    And message is sent with API call
+      """
+      {
+        "Message": {
+          "Subject": "",
+          "Sender": {
+            "Name": "Bridge Test"
+          },
+          "ToList": [
+            {
+              "Address": "bridgetest@protonmail.com",
+              "Name": "Internal Bridge"
+            }
+          ],
+          "CCList": [],
+          "BCCList": [],
+          "MIMEType": "text/plain"
+        }
+      }
+      """

test/mocks/smtp.go

@@ -75,6 +75,7 @@ func (c *SMTPClient) SendCommands(commands ...string) *SMTPResponse {
 
 	for _, command := range commands {
 		command = strings.ReplaceAll(command, "[userAddress]", c.address)
+		command = strings.ReplaceAll(command, "[userAddress|capitalize]", strings.Title(c.address))
 
 		tstart := time.Now()
 

unreleased.md

@@ -9,3 +9,5 @@ Changelog [format](http://keepachangelog.com/en/1.0.0/)
 ### Removed
 
 ### Changed
+
+### Fixed