forked from Silverfish/proton-bridge
fix(GODT-2803): Separate conditions to pause event loop for IMAP
Add two separate toggles to control event loop pausing. This is required to prevent cases where the bridge requests the event loop to be paused but a sync process completes and resumes the event loop. For the loop to resume now both states need to be set to false. This will be removed once GODT-2848 is implemented.
This commit is contained in:
@ -78,6 +78,7 @@ func TestService_EventIDLoadStore(t *testing.T) {
|
||||
)
|
||||
require.NoError(t, service.Start(context.Background(), group))
|
||||
service.Resume()
|
||||
service.ResumeIMAP()
|
||||
group.Wait()
|
||||
}
|
||||
|
||||
@ -132,6 +133,7 @@ func TestService_RetryEventOnNonCatastrophicFailure(t *testing.T) {
|
||||
|
||||
require.NoError(t, service.Start(context.Background(), group))
|
||||
service.Resume()
|
||||
service.ResumeIMAP()
|
||||
group.Wait()
|
||||
}
|
||||
|
||||
@ -194,6 +196,7 @@ func TestService_OnBadEventServiceIsPaused(t *testing.T) {
|
||||
service.Subscribe(NewCallbackSubscriber("foo", EventHandler{MessageHandler: subscriber}))
|
||||
require.NoError(t, service.Start(context.Background(), group))
|
||||
service.Resume()
|
||||
service.ResumeIMAP()
|
||||
group.Wait()
|
||||
}
|
||||
|
||||
@ -250,6 +253,7 @@ func TestService_UnsubscribeDuringEventHandlingDoesNotCauseDeadlock(t *testing.T
|
||||
service.Subscribe(subscription)
|
||||
require.NoError(t, service.Start(context.Background(), group))
|
||||
service.Resume()
|
||||
service.ResumeIMAP()
|
||||
group.Wait()
|
||||
}
|
||||
|
||||
@ -308,6 +312,7 @@ func TestService_UnsubscribeBeforeHandlingEventIsNotConsideredError(t *testing.T
|
||||
service.Subscribe(subscription)
|
||||
require.NoError(t, service.Start(context.Background(), group))
|
||||
service.Resume()
|
||||
service.ResumeIMAP()
|
||||
group.Wait()
|
||||
}
|
||||
|
||||
@ -370,6 +375,7 @@ func TestService_WaitOnEventPublishAfterPause(t *testing.T) {
|
||||
service.Subscribe(NewCallbackSubscriber("foo", EventHandler{MessageHandler: subscriber}))
|
||||
require.NoError(t, service.Start(context.Background(), group))
|
||||
service.Resume()
|
||||
service.ResumeIMAP()
|
||||
group.Wait()
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user