yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

Merge branch master into devel

Browse Source
This commit is contained in:
Jakub
2020-07-02 10:16:08 +02:00
parent 2512d3647a 5348ae7d18
commit 35ae2011b6
12 changed files with 84 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/README.md
View File

@ -36,6 +36,14 @@ graph LR
We want to test Bridge app from outside as much as possible. So we mock server (API),
credentials store and call commands to IMAP or SMTP the same way as client would do.
## Running tests
In order to run Integration tests just go into the test folder `cd test`
and run `make test`.
You can also test only specific feature (or subset of features) by using `FEATURES` environment
variable: `FEATURES=features/imap/message/create.feature make test`.
## Example test
BDD test in gherkin (cucumber) format (https://cucumber.io/docs/gherkin/reference/).
@ -99,6 +107,10 @@ we can always be sure what each steps does or should do.
In the code, we separate those parts in its own files to make sure
it's clear how the function should be implemented.
In the `Given` phase is also generally better to setup data (as `there are messages...`)
first, then users (`there is connected user...`) and then connections (`there is IMAP client...`).
This can prevent some hitches in internal implementation of integration tests.
## API faked by fakeapi or liveapi
We need to control what server returns. Instead of using raw JSONs,

15
test/features/imap/message/create.feature
View File

@ -18,7 +18,6 @@ Feature: IMAP create messages
| from | to | subject | read |
| [primary] | john.doe@email.com | foo | true |
@ignore
Scenario: Creates message sent from user's primary address
Given there is IMAP client selected in "Sent"
When IMAP client creates message "foo" from address "primary" of "userMoreAddresses" to "john.doe@email.com" with body "hello world" in "Sent"
@ -29,7 +28,6 @@ Feature: IMAP create messages
| [primary] | john.doe@email.com | foo | true |
And mailbox "INBOX" for "userMoreAddresses" has no messages
@ignore
Scenario: Creates message sent from user's secondary address
Given there is IMAP client selected in "Sent"
When IMAP client creates message "foo" from address "secondary" of "userMoreAddresses" to "john.doe@email.com" with body "hello world" in "Sent"
@ -57,3 +55,16 @@ Feature: IMAP create messages
| from | to | subject | read |
| notuser@gmail.com | alsonotuser@gmail.com | foo | true |
And mailbox "INBOX" for "userMoreAddresses" has no messages
# Importing duplicate messages when messageID cannot be found in Sent already.
#
# Previously, we discarded messages for which sender matches account address to
# avoid duplicates, but this led to discarding messages imported through mail client.
Scenario: Imports a similar (duplicate) message to sent
Given there are messages in mailbox "Sent" for "userMoreAddresses"
| from | to | subject | body |
| [primary] | chosen@one.com | Meet the Twins | Hello, Mr. Anderson |
And there is IMAP client selected in "Sent"
When IMAP client creates message "Meet the Twins" from address "primary" of "userMoreAddresses" to "chosen@one.com" with body "Hello, Mr. Anderson" in "Sent"
Then IMAP response is "OK"
And mailbox "Sent" for "userMoreAddresses" has 2 messages