yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

fix: clean up after setting result

Browse Source
This commit is contained in:
James Houlahan
2020-07-23 14:44:16 +02:00
parent c988d739a1
commit 369c6ebf85
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/confirmer/confirmer.go
View File

@ -63,5 +63,8 @@ func (c *Confirmer) SetResult(id string, value bool) error {
req.value <- value req.value <- value
close(req.value)
delete(c.requests, id)
return nil return nil
} }

6
pkg/confirmer/confirmer_test.go
View File

@ -30,7 +30,7 @@ func TestConfirmerYes(t *testing.T) {
req := c.NewRequest(1 * time.Second) req := c.NewRequest(1 * time.Second)
go func() { go func() {
assert.NoError(t, c.SetResponse(req.ID(), true)) assert.NoError(t, c.SetResult(req.ID(), true))
}() }()
res, err := req.Result() res, err := req.Result()
@ -44,7 +44,7 @@ func TestConfirmerNo(t *testing.T) {
req := c.NewRequest(1 * time.Second) req := c.NewRequest(1 * time.Second)
go func() { go func() {
assert.NoError(t, c.SetResponse(req.ID(), false)) assert.NoError(t, c.SetResult(req.ID(), false))
}() }()
res, err := req.Result() res, err := req.Result()
@ -59,7 +59,7 @@ func TestConfirmerTimeout(t *testing.T) {
go func() { go func() {
time.Sleep(2 * time.Second) time.Sleep(2 * time.Second)
assert.NoError(t, c.SetResponse(req.ID(), true)) assert.NoError(t, c.SetResult(req.ID(), true))
}() }()
_, err := req.Result() _, err := req.Result()