forked from Silverfish/proton-bridge
feat(GODT-2771): added CLI commands for cert install/uninstall/status check on macOS.
This commit is contained in:
@ -40,7 +40,7 @@ func TestCertInKeychain(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// This test require human interaction (macOS security prompts), and is disabled by default.
|
// This test require human interaction (macOS security prompts), and is disabled by default.
|
||||||
func _TestCertificateTrust(t *testing.T) {
|
func _TestCertificateTrust(t *testing.T) { //nolint:unused
|
||||||
certPEM := generatePEMCertificate(t)
|
certPEM := generatePEMCertificate(t)
|
||||||
require.False(t, isCertTrusted(certPEM))
|
require.False(t, isCertTrusted(certPEM))
|
||||||
require.NoError(t, addCertToKeychain(certPEM))
|
require.NoError(t, addCertToKeychain(certPEM))
|
||||||
@ -52,7 +52,7 @@ func _TestCertificateTrust(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// This test require human interaction (macOS security prompts), and is disabled by default.
|
// This test require human interaction (macOS security prompts), and is disabled by default.
|
||||||
func _TestInstallAndRemove(t *testing.T) {
|
func _TestInstallAndRemove(t *testing.T) { //nolint:unused
|
||||||
certPEM := generatePEMCertificate(t)
|
certPEM := generatePEMCertificate(t)
|
||||||
|
|
||||||
// fresh install
|
// fresh install
|
||||||
|
|||||||
@ -17,24 +17,48 @@
|
|||||||
|
|
||||||
package certs
|
package certs
|
||||||
|
|
||||||
import "errors"
|
import (
|
||||||
|
"errors"
|
||||||
|
|
||||||
|
"github.com/sirupsen/logrus"
|
||||||
|
)
|
||||||
|
|
||||||
var (
|
var (
|
||||||
ErrUserCanceledCertificateInstall = errors.New("the user cancelled the authorization dialog")
|
ErrUserCanceledCertificateInstall = errors.New("the user cancelled the authorization dialog")
|
||||||
)
|
)
|
||||||
|
|
||||||
type Installer struct{}
|
type Installer struct {
|
||||||
|
log *logrus.Entry
|
||||||
|
}
|
||||||
|
|
||||||
func NewInstaller() *Installer {
|
func NewInstaller() *Installer {
|
||||||
return &Installer{}
|
return &Installer{
|
||||||
|
log: logrus.WithField("pkg", "certs"),
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (installer *Installer) InstallCert(certPEM []byte) error {
|
func (installer *Installer) InstallCert(certPEM []byte) error {
|
||||||
return installCert(certPEM)
|
installer.log.Info("Installing the Bridge TLS certificate in the OS keychain")
|
||||||
|
|
||||||
|
if err := installCert(certPEM); err != nil {
|
||||||
|
installer.log.WithError(err).Error("The Bridge TLS certificate could not be installed in the OS keychain")
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
installer.log.Info("The Bridge TLS certificate was successfully installed in the OS keychain")
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (installer *Installer) UninstallCert(certPEM []byte) error {
|
func (installer *Installer) UninstallCert(certPEM []byte) error {
|
||||||
return uninstallCert(certPEM)
|
installer.log.Info("Uninstalling the Bridge TLS certificate from the OS keychain")
|
||||||
|
|
||||||
|
if err := uninstallCert(certPEM); err != nil {
|
||||||
|
installer.log.WithError(err).Error("The Bridge TLS certificate could not be uninstalled from the OS keychain")
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
installer.log.Info("The Bridge TLS certificate was successfully uninstalled from the OS keychain")
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (installer *Installer) IsCertInstalled(certPEM []byte) bool {
|
func (installer *Installer) IsCertInstalled(certPEM []byte) bool {
|
||||||
|
|||||||
@ -23,6 +23,7 @@ import (
|
|||||||
|
|
||||||
"github.com/ProtonMail/go-proton-api"
|
"github.com/ProtonMail/go-proton-api"
|
||||||
"github.com/ProtonMail/proton-bridge/v3/internal/bridge"
|
"github.com/ProtonMail/proton-bridge/v3/internal/bridge"
|
||||||
|
"github.com/ProtonMail/proton-bridge/v3/internal/certs"
|
||||||
"github.com/ProtonMail/proton-bridge/v3/internal/constants"
|
"github.com/ProtonMail/proton-bridge/v3/internal/constants"
|
||||||
"github.com/ProtonMail/proton-bridge/v3/internal/vault"
|
"github.com/ProtonMail/proton-bridge/v3/internal/vault"
|
||||||
"github.com/abiosoft/ishell"
|
"github.com/abiosoft/ishell"
|
||||||
@ -297,6 +298,17 @@ func (f *frontendCLI) configureAppleMail(c *ishell.Context) {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
cert, _ := f.bridge.GetBridgeTLSCert()
|
||||||
|
installer := certs.NewInstaller()
|
||||||
|
if !installer.IsCertInstalled(cert) {
|
||||||
|
f.Println("Apple Mail requires that a TLS certificate for bridge IMAP and SMTP server is installed in your system keychain.")
|
||||||
|
f.Println("Please provide your credentials in the system popup dialog in order to continue.")
|
||||||
|
if err := installer.InstallCert(cert); err != nil {
|
||||||
|
f.printAndLogError(err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
if err := f.bridge.ConfigureAppleMail(context.Background(), user.UserID, user.Addresses[0]); err != nil {
|
if err := f.bridge.ConfigureAppleMail(context.Background(), user.UserID, user.Addresses[0]); err != nil {
|
||||||
f.printAndLogError(err)
|
f.printAndLogError(err)
|
||||||
return
|
return
|
||||||
|
|||||||
@ -21,6 +21,7 @@ package cli
|
|||||||
import (
|
import (
|
||||||
"errors"
|
"errors"
|
||||||
"os"
|
"os"
|
||||||
|
"runtime"
|
||||||
|
|
||||||
"github.com/ProtonMail/gluon/async"
|
"github.com/ProtonMail/gluon/async"
|
||||||
"github.com/ProtonMail/proton-bridge/v3/internal/bridge"
|
"github.com/ProtonMail/proton-bridge/v3/internal/bridge"
|
||||||
@ -145,25 +146,52 @@ func New(
|
|||||||
})
|
})
|
||||||
fe.AddCmd(dohCmd)
|
fe.AddCmd(dohCmd)
|
||||||
|
|
||||||
// Apple Mail commands.
|
//goland:noinspection GoBoolExpressions
|
||||||
configureCmd := &ishell.Cmd{
|
if runtime.GOOS == "darwin" {
|
||||||
Name: "configure-apple-mail",
|
// Apple Mail commands.
|
||||||
Help: "Configures Apple Mail to use ProtonMail Bridge",
|
configureCmd := &ishell.Cmd{
|
||||||
Func: fe.configureAppleMail,
|
Name: "configure-apple-mail",
|
||||||
|
Help: "Configures Apple Mail to use ProtonMail Bridge",
|
||||||
|
Func: fe.configureAppleMail,
|
||||||
|
}
|
||||||
|
fe.AddCmd(configureCmd)
|
||||||
}
|
}
|
||||||
fe.AddCmd(configureCmd)
|
|
||||||
|
|
||||||
// TLS commands.
|
// TLS commands.
|
||||||
fe.AddCmd(&ishell.Cmd{
|
certCmd := &ishell.Cmd{
|
||||||
Name: "export-tls-cert",
|
Name: "cert",
|
||||||
Help: "Export the TLS certificate used by the Bridge",
|
Help: "Manage the TLS certificate used by Bridge",
|
||||||
|
}
|
||||||
|
|
||||||
|
//goland:noinspection GoBoolExpressions
|
||||||
|
if runtime.GOOS == "darwin" {
|
||||||
|
certCmd.AddCmd(&ishell.Cmd{
|
||||||
|
Name: "status",
|
||||||
|
Help: "Check if the TLS certificate used by Bridge is installed in the OS keychain",
|
||||||
|
Func: fe.tlsCertStatus,
|
||||||
|
})
|
||||||
|
certCmd.AddCmd(&ishell.Cmd{
|
||||||
|
Name: "install",
|
||||||
|
Help: "Install TLS certificate used by Bridge in the OS keychain",
|
||||||
|
Func: fe.installTLSCert,
|
||||||
|
})
|
||||||
|
certCmd.AddCmd(&ishell.Cmd{
|
||||||
|
Name: "uninstall",
|
||||||
|
Help: "Uninstall the TLS certificate used by Bridge from the OS keychain",
|
||||||
|
Func: fe.uninstallTLSCert,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
certCmd.AddCmd(&ishell.Cmd{
|
||||||
|
Name: "export",
|
||||||
|
Help: "Export the TLS certificate used by Bridge",
|
||||||
Func: fe.exportTLSCerts,
|
Func: fe.exportTLSCerts,
|
||||||
})
|
})
|
||||||
fe.AddCmd(&ishell.Cmd{
|
certCmd.AddCmd(&ishell.Cmd{
|
||||||
Name: "import-tls-cert",
|
Name: "import",
|
||||||
Help: "Import a TLS certificate to be used by the Bridge",
|
Help: "Import a TLS certificate to be used by Bridge",
|
||||||
Func: fe.importTLSCerts,
|
Func: fe.importTLSCerts,
|
||||||
})
|
})
|
||||||
|
fe.AddCmd(certCmd)
|
||||||
|
|
||||||
// All mail visibility commands.
|
// All mail visibility commands.
|
||||||
allMailCmd := &ishell.Cmd{
|
allMailCmd := &ishell.Cmd{
|
||||||
|
|||||||
@ -27,6 +27,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"github.com/ProtonMail/proton-bridge/v3/internal/bridge"
|
"github.com/ProtonMail/proton-bridge/v3/internal/bridge"
|
||||||
|
"github.com/ProtonMail/proton-bridge/v3/internal/certs"
|
||||||
"github.com/ProtonMail/proton-bridge/v3/pkg/ports"
|
"github.com/ProtonMail/proton-bridge/v3/pkg/ports"
|
||||||
"github.com/abiosoft/ishell"
|
"github.com/abiosoft/ishell"
|
||||||
)
|
)
|
||||||
@ -240,6 +241,50 @@ func (f *frontendCLI) setGluonLocation(c *ishell.Context) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (f *frontendCLI) tlsCertStatus(_ *ishell.Context) {
|
||||||
|
cert, _ := f.bridge.GetBridgeTLSCert()
|
||||||
|
installer := certs.NewInstaller()
|
||||||
|
if installer.IsCertInstalled(cert) {
|
||||||
|
f.Println("The Bridge TLS certificate is already installed in the OS keychain.")
|
||||||
|
} else {
|
||||||
|
f.Println("The Bridge TLS certificate is not installed in the OS keychain.")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *frontendCLI) installTLSCert(_ *ishell.Context) {
|
||||||
|
cert, _ := f.bridge.GetBridgeTLSCert()
|
||||||
|
installer := certs.NewInstaller()
|
||||||
|
if installer.IsCertInstalled(cert) {
|
||||||
|
f.printAndLogError(errors.New("the Bridge TLS certificate is already installed in the OS keychain"))
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
f.Println("Please provide your credentials in the system popup dialog in order to continue.")
|
||||||
|
if err := installer.InstallCert(cert); err != nil {
|
||||||
|
f.printAndLogError(err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
f.Println("The Bridge TLS certificate was successfully installed in the OS keychain.")
|
||||||
|
}
|
||||||
|
|
||||||
|
func (f *frontendCLI) uninstallTLSCert(_ *ishell.Context) {
|
||||||
|
cert, _ := f.bridge.GetBridgeTLSCert()
|
||||||
|
installer := certs.NewInstaller()
|
||||||
|
if !installer.IsCertInstalled(cert) {
|
||||||
|
f.printAndLogError(errors.New("the Bridge TLS certificate is not installed in the OS keychain"))
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
f.Println("Please provide your credentials in the system popup dialog in order to continue.")
|
||||||
|
if err := installer.UninstallCert(cert); err != nil {
|
||||||
|
f.printAndLogError(err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
f.Println("The Bridge TLS certificate was successfully uninstalled from the OS keychain.")
|
||||||
|
}
|
||||||
|
|
||||||
func (f *frontendCLI) exportTLSCerts(c *ishell.Context) {
|
func (f *frontendCLI) exportTLSCerts(c *ishell.Context) {
|
||||||
if location := f.readStringInAttempts("Enter a path to which to export the TLS certificate used for IMAP and SMTP", c.ReadLine, f.isCacheLocationUsable); location != "" {
|
if location := f.readStringInAttempts("Enter a path to which to export the TLS certificate used for IMAP and SMTP", c.ReadLine, f.isCacheLocationUsable); location != "" {
|
||||||
cert, key := f.bridge.GetBridgeTLSCert()
|
cert, key := f.bridge.GetBridgeTLSCert()
|
||||||
|
|||||||
Reference in New Issue
Block a user