yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

GODT-1105 Fix: Dylib hijack vulnerability found by https://objective-see.com/products/dhs.html

Browse Source
This commit is contained in:
Jakub
2021-03-22 13:19:16 +01:00
committed by Jakub Cuth
parent 72fe5a636e
commit 59e0d63485
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
utils/remove_non_relative_links_darwin.sh
View File

@ -17,10 +17,13 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with ProtonMail Bridge. If not, see <https://www.gnu.org/licenses/>. # along with ProtonMail Bridge. If not, see <https://www.gnu.org/licenses/>.
# The Qt libs are dynamically loaded with rules like: `@rpath/QtGui.framework/Versions/5/QtGui`
## Make sure that mac exe will not contain broken library links # @rpath instructs the dynamic linker to search a list of paths in order to locate the framework
# * remove absolute paths for Qt libs # The rules can be listed using `otool -l "${path_to_binary}"`
# * add relative part to app bundle Frameworks # The building process of therecipe/qt or qmake leaves the rules with additinal unwanted paths
# + absolute path to build directory
# + dummy replacement `/break_the_rpath`
# We need to manually remove those and add the path relative to exectuable: `@executable_path/../Frameworks`
path_to_binary=$1 path_to_binary=$1
@ -29,11 +32,11 @@ if [ -z ${path_to_binary} ]; then
exit 2 exit 2
fi fi
for remove_path_qt in $(otool -l "${path_to_binary}" | grep '/Users/' | awk '{print $2}'); for path_to_remove in $(otool -l "${path_to_binary}" | egrep '/Users/|break_the_rpath' | awk '{print $2}');
do do
if [ ! -z "${remove_path_qt}" ]; then if [ ! -z "${path_to_remove}" ]; then
printf "\e[0;32mRemove path to qt ${remove_path_qt} ...\033[0m\n\e[0;31m" printf "\e[0;32mRemove path to qt '${path_to_remove}' ...\033[0m\n\e[0;31m"
install_name_tool -delete_rpath "${remove_path_qt}" "${path_to_binary}" || exit 1 install_name_tool -delete_rpath "${path_to_remove}" "${path_to_binary}" || exit 1
fi fi
done done
rpath_rule=$(otool -l "${path_to_binary}" | grep executable_path | awk '{print $2}') rpath_rule=$(otool -l "${path_to_binary}" | grep executable_path | awk '{print $2}')