yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

chore: tidy up before merge

Browse Source
This commit is contained in:
James Houlahan
2020-09-14 14:08:05 +02:00
parent 97b64ebb70
commit 5bca6fc3cf
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/message/parser.go
View File

@ -91,7 +91,6 @@ func Parse(r io.Reader, key, keyName string) (m *pmapi.Message, mimeBody, plainB
func convertForeignEncodings(p *parser.Parser) error { func convertForeignEncodings(p *parser.Parser) error {
logrus.Debug("Converting foreign encodings") logrus.Debug("Converting foreign encodings")
// HELP: Is it correct to only do this to text types?
return p.NewWalker(). return p.NewWalker().
RegisterContentTypeHandler("text/html", func(p *parser.Part) error { RegisterContentTypeHandler("text/html", func(p *parser.Part) error {
if err := p.ConvertToUTF8(); err != nil { if err := p.ConvertToUTF8(); err != nil {

4
test/features/bridge/smtp/send/plain.feature
View File

@ -222,8 +222,6 @@ Feature: SMTP sending of plain messages
} }
""" """
# HELP: This is strange... why do we want this behaviour?
@ignore
Scenario: Message without charset and content is detected as HTML Scenario: Message without charset and content is detected as HTML
When SMTP client sends message When SMTP client sends message
""" """
@ -254,7 +252,7 @@ Feature: SMTP sending of plain messages
], ],
"CCList": [], "CCList": [],
"BCCList": [], "BCCList": [],
"MIMEType": "text/html" "MIMEType": "text/plain"
} }
} }
""" """