yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

fix(GODT-2913): Reduce the number of configuration failure detected.

Browse Source
This commit is contained in:
Romain Le Jeune
2023-09-08 11:53:24 +00:00
parent 79524185a8
commit 6269b1ab88
7 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/services/useridentity/service.go
View File

@ -249,7 +249,7 @@ func (s *Service) run(ctx context.Context) {
r.Reply(ctx, maps.Clone(s.identity.Addresses), nil)
case *checkAuthReq:
id, err := s.identity.CheckAuth(req.email, req.password, s.bridgePassProvider, s.telemetry)
id, err := s.identity.CheckAuth(req.email, req.password, s.bridgePassProvider)
r.Reply(ctx, id, err)
default:

8
internal/services/useridentity/state.go
View File

@ -226,7 +226,7 @@ func (s *State) Clone() *State {
// CheckAuth returns whether the given email and password can be used to authenticate over IMAP or SMTP with this user.
// It returns the address ID of the authenticated address.
func (s *State) CheckAuth(email string, password []byte, bridgePassProvider BridgePassProvider, telemetry Telemetry) (string, error) {
func (s *State) CheckAuth(email string, password []byte, bridgePassProvider BridgePassProvider) (string, error) {
if email == "crash@bandicoot" {
panic("your wish is my command.. I crash")
}
@ -237,11 +237,7 @@ func (s *State) CheckAuth(email string, password []byte, bridgePassProvider Brid
}
if subtle.ConstantTimeCompare(bridgePassProvider.BridgePass(), dec) != 1 {
err := fmt.Errorf("invalid password")
if telemetry != nil {
telemetry.ReportConfigStatusFailure(err.Error())
}
return "", err
return "", fmt.Errorf("invalid password")
}
for _, addr := range s.AddressesSorted {