yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

test: Improve TestMetadata_JobCorrectlyFinishesAfterCancel

Browse Source
This commit is contained in:
Leander Beernaert
2023-12-04 13:32:00 +01:00
parent dd9a819ea2
commit 6cbef1d786
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/services/syncservice/stage_metadata_test.go
View File

@ -102,9 +102,6 @@ func TestMetadataStage_JobCorrectlyFinishesAfterCancel(t *testing.T) {
// read one output then cancel // read one output then cancel
request, err := output.Consume(ctx) request, err := output.Consume(ctx)
require.NoError(t, err) require.NoError(t, err)
request.onFinished(ctx)
// cancel job context
jobCancel()
wg := sync.WaitGroup{} wg := sync.WaitGroup{}
wg.Add(1) wg.Add(1)
@ -117,10 +114,13 @@ func TestMetadataStage_JobCorrectlyFinishesAfterCancel(t *testing.T) {
return return
} }
// cancel job context
jobCancel()
req.checkCancelled() req.checkCancelled()
} }
}() }()
wg.Wait() wg.Wait()
request.onFinished(ctx)
err = tj.job.waitAndClose(ctx) err = tj.job.waitAndClose(ctx)
require.Error(t, err) require.Error(t, err)
require.ErrorIs(t, err, context.Canceled) require.ErrorIs(t, err, context.Canceled)