yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

test: Fix event registration in TestBridge_SyncWithOngoingEvents

Browse Source 
We need to register the event subscriber earlier to avoid missing the
event later.
This commit is contained in:
Leander Beernaert
2023-07-31 08:28:54 +02:00
parent 750de0cd31
commit 716de7f45a
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
internal/bridge/sync_test.go
View File

@ -252,14 +252,17 @@ func TestBridge_SyncWithOngoingEvents(t *testing.T) {
// Login the user; its sync should fail. // Login the user; its sync should fail.
withBridge(ctx, t, s.GetHostURL(), netCtl, locator, storeKey, func(b *bridge.Bridge, mocks *bridge.Mocks) { withBridge(ctx, t, s.GetHostURL(), netCtl, locator, storeKey, func(b *bridge.Bridge, mocks *bridge.Mocks) {
syncCh, done := chToType[events.Event, events.SyncFinished](b.GetEvents(events.SyncFinished{}))
defer done()
{ {
syncCh, done := chToType[events.Event, events.SyncFailed](b.GetEvents(events.SyncFailed{})) syncFailedCh, syncFailedDone := chToType[events.Event, events.SyncFailed](b.GetEvents(events.SyncFailed{}))
defer done() defer syncFailedDone()
userID, err := b.LoginFull(ctx, "imap", password, nil, nil) userID, err := b.LoginFull(ctx, "imap", password, nil, nil)
require.NoError(t, err) require.NoError(t, err)
require.Equal(t, userID, (<-syncCh).UserID) require.Equal(t, userID, (<-syncFailedCh).UserID)
info, err := b.GetUserInfo(userID) info, err := b.GetUserInfo(userID)
require.NoError(t, err) require.NoError(t, err)
@ -282,11 +285,7 @@ func TestBridge_SyncWithOngoingEvents(t *testing.T) {
// Remove the network limit, allowing the sync to finish. // Remove the network limit, allowing the sync to finish.
netCtl.SetReadLimit(0) netCtl.SetReadLimit(0)
{ {
syncCh, done := chToType[events.Event, events.SyncFinished](b.GetEvents(events.SyncFinished{}))
defer done()
require.Equal(t, userID, (<-syncCh).UserID) require.Equal(t, userID, (<-syncCh).UserID)
info, err := b.GetUserInfo(userID) info, err := b.GetUserInfo(userID)