From 73d1fe2f653ea47a3535d247267442cfe019fa7a Mon Sep 17 00:00:00 2001 From: Jakub Date: Tue, 1 Mar 2022 15:08:30 +0100 Subject: [PATCH] GODT-1516 GODT-1451: KeepassXC is crashing on start. We need to block it until it's fixed. --- README.md | 4 +++- pkg/keychain/helper_linux.go | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index f560d3f3..1c8226b4 100644 --- a/README.md +++ b/README.md @@ -56,7 +56,9 @@ You need to have a keychain in order to run the ProtonMail Bridge. On Mac or Windows, Bridge uses native credential managers. On Linux, use `secret-service` freedesktop.org API (e.g. [Gnome keyring](https://wiki.gnome.org/Projects/GnomeKeyring/)) or -[pass](https://www.passwordstore.org/). +[pass](https://www.passwordstore.org/). We are working on allowing other secret +services (e.g. KeepassXC), but for now only gnome-keyring is usable without +major problems. ## Environment Variables diff --git a/pkg/keychain/helper_linux.go b/pkg/keychain/helper_linux.go index 2f48f76c..53b4c658 100644 --- a/pkg/keychain/helper_linux.go +++ b/pkg/keychain/helper_linux.go @@ -35,7 +35,7 @@ const ( func init() { // nolint[noinit] Helpers = make(map[string]helperConstructor) - if isUsable(newSecretServiceHelper("")) { + if _, err := exec.LookPath("gnome-keyring"); err == nil && isUsable(newSecretServiceHelper("")) { Helpers[SecretService] = newSecretServiceHelper }