Other(refactor): Remove unused frontend args

This commit is contained in:
James Houlahan
2022-08-18 15:03:04 +02:00
committed by Jakub
parent aa5c3042da
commit 743a2f8dac
4 changed files with 8 additions and 21 deletions

View File

@ -17,13 +17,14 @@
// Package base implements a common application base currently shared by bridge and IE.
// The base includes the following:
// - access to standard filesystem locations like config, cache, logging dirs
// - an extensible crash handler
// - versioned cache directory
// - persistent settings
// - event listener
// - credentials store
// - pmapi Manager
// - access to standard filesystem locations like config, cache, logging dirs
// - an extensible crash handler
// - versioned cache directory
// - persistent settings
// - event listener
// - credentials store
// - pmapi Manager
//
// In addition, the base initialises logging and reacts to command line arguments
// which control the log verbosity and enable cpu/memory profiling.
package base

View File

@ -156,9 +156,6 @@ func mailLoop(b *base.Base, c *cli.Context) error { //nolint:funlen
}
f := frontend.New(
constants.Version,
constants.BuildVersion,
b.Name,
frontendMode,
!c.Bool(base.FlagNoWindow),
b.CrashHandler,

View File

@ -42,9 +42,6 @@ type Frontend interface {
// New returns initialized frontend based on `frontendType`, which can be `cli` or `grpc`.
func New(
version,
buildVersion,
programName,
frontendType string,
showWindowOnStart bool,
panicHandler types.PanicHandler,
@ -62,8 +59,6 @@ func New(
switch frontendType {
case "grpc":
return grpc.NewService(
version,
programName,
showWindowOnStart,
panicHandler,
tls,

View File

@ -52,8 +52,6 @@ type Service struct { // nolint:structcheck
eventStreamCh chan *StreamEvent
eventStreamDoneCh chan struct{}
programName string
programVersion string
panicHandler types.PanicHandler
tls *bridgetls.TLS
locations *locations.Locations
@ -77,8 +75,6 @@ type Service struct { // nolint:structcheck
// NewService returns a new instance of the service.
func NewService(
version,
programName string,
showOnStartup bool,
panicHandler types.PanicHandler,
tls *bridgetls.TLS,
@ -94,8 +90,6 @@ func NewService(
) *Service {
s := Service{
UnimplementedBridgeServer: UnimplementedBridgeServer{},
programName: programName,
programVersion: version,
panicHandler: panicHandler,
tls: tls,
locations: locations,