From 76f2e7fdb990844cd4e86ca68f8478c938eee378 Mon Sep 17 00:00:00 2001
From: Leander Beernaert <leander.beernaert@proton.ch>
Date: Tue, 26 Sep 2023 09:45:27 +0200
Subject: [PATCH] fix(GODT-2951): Negative WaitGroup Counter

Do not defer call to `wg.Done()` in `job.onJobFinished`. If there is an
error it will also call `wg.Done()`.
---
 internal/services/syncservice/job.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/internal/services/syncservice/job.go b/internal/services/syncservice/job.go
index 8978ae6b..cad55c90 100644
--- a/internal/services/syncservice/job.go
+++ b/internal/services/syncservice/job.go
@@ -113,13 +113,14 @@ func (j *Job) onStageCompleted(ctx context.Context, count int64) {
 }
 
 func (j *Job) onJobFinished(ctx context.Context, lastMessageID string, count int64) {
-	defer j.wg.Done()
-
 	if err := j.state.SetLastMessageID(ctx, lastMessageID, count); err != nil {
 		j.log.WithError(err).Error("Failed to store last synced message id")
 		j.onError(err)
 		return
 	}
+
+	// j.onError() also calls j.wg.Done().
+	j.wg.Done()
 	j.syncReporter.OnProgress(ctx, count)
 }