yesBad/proton-bridge
1
0
Fork 0
Code Actions Activity

fix: mime type

Browse Source
This commit is contained in:
James Houlahan
2020-08-13 11:21:37 +02:00
parent 34df24ede3
commit 77c6ba381e
4 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
internal/smtp/preferences_test.go
View File

@ -51,7 +51,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{}, contactMeta: &ContactMetadata{},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: true, isInternal: true,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -66,7 +66,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{MIMEType: "text/plain"}, contactMeta: &ContactMetadata{MIMEType: "text/plain"},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: true, isInternal: true,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -81,7 +81,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Keys: []string{testContactKey}}, contactMeta: &ContactMetadata{Keys: []string{testContactKey}},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: true, isInternal: true,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -97,7 +97,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Keys: []string{testOtherContactKey}}, contactMeta: &ContactMetadata{Keys: []string{testOtherContactKey}},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: true, isInternal: true,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -112,7 +112,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{}, contactMeta: &ContactMetadata{},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -127,7 +127,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{MIMEType: "text/plain"}, contactMeta: &ContactMetadata{MIMEType: "text/plain"},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -142,7 +142,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{}, contactMeta: &ContactMetadata{},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPInlinePackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPInlinePackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -157,7 +157,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Scheme: pgpInline}, contactMeta: &ContactMetadata{Scheme: pgpInline},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -172,7 +172,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Scheme: pgpMIME}, contactMeta: &ContactMetadata{Scheme: pgpMIME},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPInlinePackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPInlinePackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -187,7 +187,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Keys: []string{testContactKey}}, contactMeta: &ContactMetadata{Keys: []string{testContactKey}},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -203,7 +203,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Keys: []string{testOtherContactKey}}, contactMeta: &ContactMetadata{Keys: []string{testOtherContactKey}},
receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}}, receivedKeys: []pmapi.PublicKey{{PublicKey: testPublicKey}},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -218,7 +218,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{}, contactMeta: &ContactMetadata{},
receivedKeys: []pmapi.PublicKey{}, receivedKeys: []pmapi.PublicKey{},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: false, wantEncrypt: false,
wantSign: false, wantSign: false,
@ -232,7 +232,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{MIMEType: "text/plain"}, contactMeta: &ContactMetadata{MIMEType: "text/plain"},
receivedKeys: []pmapi.PublicKey{}, receivedKeys: []pmapi.PublicKey{},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: false, wantEncrypt: false,
wantSign: false, wantSign: false,
@ -246,7 +246,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Sign: true}, contactMeta: &ContactMetadata{Sign: true},
receivedKeys: []pmapi.PublicKey{}, receivedKeys: []pmapi.PublicKey{},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: false, wantEncrypt: false,
wantSign: true, wantSign: true,
@ -260,7 +260,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Keys: []string{testContactKey}}, contactMeta: &ContactMetadata{Keys: []string{testContactKey}},
receivedKeys: []pmapi.PublicKey{}, receivedKeys: []pmapi.PublicKey{},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: false, wantEncrypt: false,
wantSign: false, wantSign: false,
@ -275,7 +275,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Keys: []string{testContactKey}, Encrypt: true, Sign: true}, contactMeta: &ContactMetadata{Keys: []string{testContactKey}, Encrypt: true, Sign: true},
receivedKeys: []pmapi.PublicKey{}, receivedKeys: []pmapi.PublicKey{},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -290,7 +290,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Keys: []string{testContactKey}, Encrypt: true, Sign: true, Scheme: pgpInline}, contactMeta: &ContactMetadata{Keys: []string{testContactKey}, Encrypt: true, Sign: true, Scheme: pgpInline},
receivedKeys: []pmapi.PublicKey{}, receivedKeys: []pmapi.PublicKey{},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPMIMEPackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,
@ -305,7 +305,7 @@ func TestPreferencesBuilder(t *testing.T) {
contactMeta: &ContactMetadata{Keys: []string{testContactKey}, Encrypt: true, Sign: true}, contactMeta: &ContactMetadata{Keys: []string{testContactKey}, Encrypt: true, Sign: true},
receivedKeys: []pmapi.PublicKey{}, receivedKeys: []pmapi.PublicKey{},
isInternal: false, isInternal: false,
mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPInlinePackage}, mailSettings: pmapi.MailSettings{PGPScheme: pmapi.PGPInlinePackage, ComposerMode: pmapi.ComposerModeNormal},
wantEncrypt: true, wantEncrypt: true,
wantSign: true, wantSign: true,

1
internal/smtp/user.go
View File

@ -364,6 +364,7 @@ func (su *smtpUser) Send(from string, to []string, messageReader io.Reader) (err
if plainPkg != nil { if plainPkg != nil {
req.Packages = append(req.Packages, plainPkg) req.Packages = append(req.Packages, plainPkg)
} }
htmlPkg := buildPackage(htmlAddressMap, htmlSharedScheme, pmapi.ContentTypeHTML, htmlData, htmlKey, attkeysEncoded) htmlPkg := buildPackage(htmlAddressMap, htmlSharedScheme, pmapi.ContentTypeHTML, htmlData, htmlKey, attkeysEncoded)
if htmlPkg != nil { if htmlPkg != nil {
req.Packages = append(req.Packages, htmlPkg) req.Packages = append(req.Packages, htmlPkg)

2
internal/smtp/utils.go
View File

@ -102,12 +102,14 @@ func buildPackage(
if len(addressMap) == 0 { if len(addressMap) == 0 {
return nil return nil
} }
pkg = &pmapi.MessagePackage{ pkg = &pmapi.MessagePackage{
Body: base64.StdEncoding.EncodeToString(bodyData), Body: base64.StdEncoding.EncodeToString(bodyData),
Addresses: addressMap, Addresses: addressMap,
MIMEType: mimeType, MIMEType: mimeType,
Type: sharedScheme, Type: sharedScheme,
} }
if sharedScheme|pmapi.ClearPackage > 0 { if sharedScheme|pmapi.ClearPackage > 0 {
pkg.BodyKey.Key = bodyKey.GetBase64Key() pkg.BodyKey.Key = bodyKey.GetBase64Key()
pkg.BodyKey.Algorithm = bodyKey.Algo pkg.BodyKey.Algorithm = bodyKey.Algo

4
pkg/pmapi/settings.go
View File

@ -98,8 +98,8 @@ type MailSettings struct {
} }
const ( const (
ComposerModeNormal = 0 ComposerModePlain = 0
ComposerModePlain = 1 ComposerModeNormal = 1
) )
// GetMailSettings gets contact details specified by contact ID. // GetMailSettings gets contact details specified by contact ID.