yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

Other: Lint fixes

Browse Source
This commit is contained in:
James Houlahan
2022-10-27 11:14:36 +02:00
parent d4da325e57
commit 7e03de0a21
4 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/safe/mutex.go
View File

@ -24,7 +24,7 @@ import (
"golang.org/x/exp/slices" "golang.org/x/exp/slices"
) )
var nextMutexID uint64 var nextMutexID uint64 // nolint:gochecknoglobals
// Mutex is a mutex that can be locked and unlocked. // Mutex is a mutex that can be locked and unlocked.
type Mutex interface { type Mutex interface {

5
internal/user/types.go
View File

@ -58,11 +58,6 @@ func groupBy[Key comparable, Value any](items []Value, key func(Value) Key) map[
return groups return groups
} }
// sortAddr returns whether the first address should be sorted before the second.
func sortAddr(addrIDA, addrIDB string, apiAddrs map[string]liteapi.Address) bool {
return apiAddrs[addrIDA].Order < apiAddrs[addrIDB].Order
}
// hexEncode returns the hexadecimal encoding of the given byte slice. // hexEncode returns the hexadecimal encoding of the given byte slice.
func hexEncode(b []byte) []byte { func hexEncode(b []byte) []byte {
enc := make([]byte, hex.EncodedLen(len(b))) enc := make([]byte, hex.EncodedLen(len(b)))

5
tests/bdd_test.go
View File

@ -27,7 +27,6 @@ import (
"github.com/ProtonMail/proton-bridge/v2/internal/certs" "github.com/ProtonMail/proton-bridge/v2/internal/certs"
"github.com/ProtonMail/proton-bridge/v2/internal/user" "github.com/ProtonMail/proton-bridge/v2/internal/user"
"github.com/cucumber/godog" "github.com/cucumber/godog"
"github.com/stretchr/testify/require"
"gitlab.protontech.ch/go/liteapi/server/backend" "gitlab.protontech.ch/go/liteapi/server/backend"
) )
@ -53,8 +52,8 @@ func (s *scenario) reset(tb testing.TB) {
s.t = newTestCtx(tb) s.t = newTestCtx(tb)
} }
func (s *scenario) close(tb testing.TB) { func (s *scenario) close(_ testing.TB) {
require.NoError(tb, s.t.close(context.Background())) s.t.close(context.Background())
} }
func TestFeatures(testingT *testing.T) { func TestFeatures(testingT *testing.T) {

4
tests/ctx_test.go
View File

@ -247,7 +247,7 @@ func (t *testCtx) getLastError() error {
return nil return nil
} }
func (t *testCtx) close(ctx context.Context) error { func (t *testCtx) close(ctx context.Context) {
for _, client := range t.imapClients { for _, client := range t.imapClients {
if err := client.client.Logout(); err != nil { if err := client.client.Logout(); err != nil {
logrus.WithError(err).Error("Failed to logout IMAP client") logrus.WithError(err).Error("Failed to logout IMAP client")
@ -267,8 +267,6 @@ func (t *testCtx) close(ctx context.Context) error {
t.api.Close() t.api.Close()
t.events.close() t.events.close()
return nil
} }
type eventCollector struct { type eventCollector struct {