yesBad/proton-bridge
1
0
Fork 0
Code Actions Activity

fix(GODT-2442): must publish loggedOut event.

Browse Source
This commit is contained in:
Jakub
2023-03-07 18:56:06 +01:00
parent b953468af2
commit 7fc907a874
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
internal/bridge/user.go
View File

@ -343,6 +343,11 @@ func (bridge *Bridge) SendBadEventUserFeedback(_ context.Context, userID string,
} }
bridge.logoutUser(ctx, user, true, false) bridge.logoutUser(ctx, user, true, false)
bridge.publish(events.UserLoggedOut{
UserID: userID,
})
return nil return nil
}, bridge.usersLock) }, bridge.usersLock)
} }

5
internal/bridge/user_event_test.go
View File

@ -100,9 +100,14 @@ func TestBridge_User_BadMessage_BadEvent(t *testing.T) {
})) }))
t.Run("LogoutAndLogin", test_badMessage_badEvent(func(t *testing.T, ctx context.Context, bridge *bridge.Bridge, badUserID string) { t.Run("LogoutAndLogin", test_badMessage_badEvent(func(t *testing.T, ctx context.Context, bridge *bridge.Bridge, badUserID string) {
logoutCh, closeCh := chToType[events.Event, events.UserLoggedOut](bridge.GetEvents(events.UserLoggedOut{}))
// User feedback is logout // User feedback is logout
require.NoError(t, bridge.SendBadEventUserFeedback(ctx, badUserID, false)) require.NoError(t, bridge.SendBadEventUserFeedback(ctx, badUserID, false))
require.Equal(t, badUserID, (<-logoutCh).UserID)
closeCh()
// The user will eventually be logged out due to the bad request errors. // The user will eventually be logged out due to the bad request errors.
require.Eventually(t, func() bool { require.Eventually(t, func() bool {
return len(bridge.GetUserIDs()) == 1 && len(getConnectedUserIDs(t, bridge)) == 0 return len(bridge.GetUserIDs()) == 1 && len(getConnectedUserIDs(t, bridge)) == 0