MR comments

This commit is contained in:
James Houlahan
2020-12-23 11:37:57 +00:00
parent 7b84038bf4
commit 805544ffb0
4 changed files with 7 additions and 7 deletions

View File

@ -64,8 +64,8 @@ type VersionInfo struct {
// "RolloutProportion": 0.5
// },
// "early": {
// "Version": "2.4.0-early",
// "Package": "https://protonmail.com/.../bridge_2.4.0-early_linux.tgz",
// "Version": "2.4.0",
// "Package": "https://protonmail.com/.../bridge_2.4.0_linux.tgz",
// "Installers": [
// "https://protonmail.com/.../something.deb",
// "https://protonmail.com/.../something.rpm",

View File

@ -35,7 +35,7 @@ func TestRemoveOldVersions(t *testing.T) {
updates, err := ioutil.TempDir("", "updates")
require.NoError(t, err)
v := newTestVersioner(t, "myCoolApp", updates, "2.3.4-early", "2.3.4", "2.3.5", "2.4.0")
v := newTestVersioner(t, "myCoolApp", updates, "2.3.4-beta", "2.3.4", "2.3.5", "2.4.0")
allVersions, err := v.ListVersions()
require.NoError(t, err)

View File

@ -32,7 +32,7 @@ func TestListVersions(t *testing.T) {
updates, err := ioutil.TempDir("", "updates")
require.NoError(t, err)
v := newTestVersioner(t, "myCoolApp", updates, "2.3.4-early", "2.3.4", "2.3.5", "2.4.0")
v := newTestVersioner(t, "myCoolApp", updates, "2.3.4-beta", "2.3.4", "2.3.5", "2.4.0")
versions, err := v.ListVersions()
require.NoError(t, err)
@ -46,8 +46,8 @@ func TestListVersions(t *testing.T) {
assert.Equal(t, semver.MustParse("2.3.4"), versions[2].version)
assert.Equal(t, filepath.Join(updates, "2.3.4"), versions[2].path)
assert.Equal(t, semver.MustParse("2.3.4-early"), versions[3].version)
assert.Equal(t, filepath.Join(updates, "2.3.4-early"), versions[3].path)
assert.Equal(t, semver.MustParse("2.3.4-beta"), versions[3].version)
assert.Equal(t, filepath.Join(updates, "2.3.4-beta"), versions[3].path)
}
func newTestVersioner(t *testing.T, exeName, updates string, versions ...string) *Versioner {

View File

@ -15,7 +15,7 @@ Changelog [format](http://keepachangelog.com/en/1.0.0/)
* GODT-874 Added manual triggers to Updater module.
### Changed
* renames channels `beta->early`, `live->stable`
* Rename channels `beta->early`, `live->stable`.
* GODT-893 Bump go-rfc5322 dependency to v0.2.1 to properly detect syntax errors during parsing.
* GODT-892 Swap type and value from sentry exception and cut panic handlers from the traceback.
* GODT-854 EXPUNGE and FETCH unilateral responses are returned before OK EXPUNGE or OK STORE, respectively.