yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

Other(refactor): Remove always-nil return value of (*Bridge).Close

Browse Source
This commit is contained in:
James Houlahan
2022-10-26 23:09:05 +02:00
parent 2bda47fcad
commit 8749d5dc7d
5 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/ctx_bridge_test.go
View File

@ -106,10 +106,12 @@ func (t *testCtx) startBridge() error {
}
func (t *testCtx) stopBridge() error {
if err := t.bridge.Close(context.Background()); err != nil {
return err
if t.bridge == nil {
return fmt.Errorf("bridge is not running")
}
t.bridge.Close(context.Background())
t.bridge = nil
return nil

4
tests/ctx_test.go
View File

@ -261,9 +261,7 @@ func (t *testCtx) close(ctx context.Context) error {
}
if t.bridge != nil {
if err := t.bridge.Close(ctx); err != nil {
return err
}
t.bridge.Close(ctx)
}
t.api.Close()