yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

fix(GODT-2708): fix dimensions event format + handling of ReportClicked event.

Browse Source
This commit is contained in:
Romain Le Jeune
2023-07-04 09:59:43 +00:00
parent 7e9a5934c5
commit 9c389e3007
11 changed files with 76 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/configstatus/configuration_abort_test.go
View File

@ -38,9 +38,9 @@ func TestConfigurationAbort_default(t *testing.T) {
require.Equal(t, "bridge.any.configuration", req.MeasurementGroup)
require.Equal(t, "bridge_config_abort", req.Event)
require.Equal(t, 0, req.Values.Duration)
require.Equal(t, false, req.Dimensions.ReportClick)
require.Equal(t, false, req.Dimensions.ReportSent)
require.Equal(t, uint64(0), req.Dimensions.ClickedLink)
require.Equal(t, "false", req.Dimensions.ReportClick)
require.Equal(t, "false", req.Dimensions.ReportSent)
require.Equal(t, "", req.Dimensions.ClickedLink)
}
func TestConfigurationAbort_fed(t *testing.T) {
@ -69,7 +69,7 @@ func TestConfigurationAbort_fed(t *testing.T) {
require.Equal(t, "bridge.any.configuration", req.MeasurementGroup)
require.Equal(t, "bridge_config_abort", req.Event)
require.Equal(t, 10, req.Values.Duration)
require.Equal(t, true, req.Dimensions.ReportClick)
require.Equal(t, false, req.Dimensions.ReportSent)
require.Equal(t, uint64(42), req.Dimensions.ClickedLink)
require.Equal(t, "true", req.Dimensions.ReportClick)
require.Equal(t, "false", req.Dimensions.ReportSent)
require.Equal(t, "[1,3,5]", req.Dimensions.ClickedLink)
}