feat(GODT-2666): feat(GODT-2667): introduce sessionID in bridge.

internal/logging/rotator_test.go

@@ -19,8 +19,10 @@ package logging
 
 import (
 	"bytes"
+	"fmt"
 	"io"
 	"os"
+	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -38,7 +40,7 @@ func (c *WriteCloser) Close() error {
 func TestRotator(t *testing.T) {
 	n := 0
 
-	getFile := func() (io.WriteCloser, error) {
+	getFile := func(_ int) (io.WriteCloser, error) {
 		n++
 		return &WriteCloser{}, nil
 	}
@@ -75,11 +77,70 @@ func TestRotator(t *testing.T) {
 	assert.Equal(t, 4, n)
 }
 
+func countFilesMatching(pattern string) int {
+	files, err := filepath.Glob(pattern)
+	if err != nil {
+		return -1
+	}
+
+	return len(files)
+}
+
+func cleanupLogs(t *testing.T, sessionID SessionID) {
+	paths, err := filepath.Glob(filepath.Join(os.TempDir(), string(sessionID)+"*.log"))
+	require.NoError(t, err)
+	for _, path := range paths {
+		require.NoError(t, os.Remove(path))
+	}
+}
+
+func TestDefaultRotator(t *testing.T) {
+	fiveBytes := []byte("00000")
+	tmpDir := os.TempDir()
+
+	sessionID := NewSessionID()
+	basePath := filepath.Join(tmpDir, string(sessionID))
+
+	r, err := NewDefaultRotator(tmpDir, sessionID, "bridge", 10)
+	require.NoError(t, err)
+	require.Equal(t, 1, countFilesMatching(basePath+"_000_*.log"))
+	require.Equal(t, 1, countFilesMatching(basePath+"*.log"))
+
+	_, err = r.Write(fiveBytes)
+	require.NoError(t, err)
+	require.Equal(t, 1, countFilesMatching(basePath+"*.log"))
+
+	_, err = r.Write(fiveBytes)
+	require.NoError(t, err)
+	require.Equal(t, 1, countFilesMatching(basePath+"*.log"))
+
+	_, err = r.Write(fiveBytes)
+	require.NoError(t, err)
+	require.Equal(t, 2, countFilesMatching(basePath+"*.log"))
+	require.Equal(t, 1, countFilesMatching(basePath+"_001_*.log"))
+
+	for i := 0; i < 4; i++ {
+		_, err = r.Write(fiveBytes)
+		require.NoError(t, err)
+	}
+
+	require.NoError(t, r.wc.Close())
+
+	// total written: 35 bytes, i.e. 4 log files
+	logFileCount := countFilesMatching(basePath + "*.log")
+	require.Equal(t, 4, logFileCount)
+	for i := 0; i < logFileCount; i++ {
+		require.Equal(t, 1, countFilesMatching(basePath+fmt.Sprintf("_%03d_*.log", i)))
+	}
+
+	cleanupLogs(t, sessionID)
+}
+
 func BenchmarkRotate(b *testing.B) {
 	benchRotate(b, MaxLogSize, getTestFile(b, b.TempDir(), MaxLogSize-1))
 }
 
-func benchRotate(b *testing.B, logSize int, getFile func() (io.WriteCloser, error)) {
+func benchRotate(b *testing.B, logSize int, getFile func(index int) (io.WriteCloser, error)) {
 	r, err := NewRotator(logSize, getFile)
 	require.NoError(b, err)
 
@@ -92,8 +153,8 @@ func benchRotate(b *testing.B, logSize int, getFile func() (io.WriteCloser, erro
 	}
 }
 
-func getTestFile(b *testing.B, dir string, length int) func() (io.WriteCloser, error) {
-	return func() (io.WriteCloser, error) {
+func getTestFile(b *testing.B, dir string, length int) func(int) (io.WriteCloser, error) {
+	return func(index int) (io.WriteCloser, error) {
 		b.StopTimer()
 		defer b.StartTimer()