From bfc4069df4b559ae7e303263606b646ee36381ba Mon Sep 17 00:00:00 2001
From: James Houlahan <james.houlahan@protonmail.com>
Date: Thu, 16 Apr 2020 15:21:31 +0200
Subject: [PATCH] feat: remove user from bridge users list if init failed

---
 internal/bridge/bridge.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/internal/bridge/bridge.go b/internal/bridge/bridge.go
index edf8eb34..1787a92b 100644
--- a/internal/bridge/bridge.go
+++ b/internal/bridge/bridge.go
@@ -332,10 +332,10 @@ func (b *Bridge) addNewUser(user *pmapi.User, auth *pmapi.Auth, hashedPassword s
 	}
 
 	// The user needs to be part of the users list in order for it to receive an auth during initialisation.
-	// TODO: If adding the user fails, we don't want to leave it there.
 	b.users = append(b.users, bridgeUser)
 
 	if err = bridgeUser.init(b.idleUpdates); err != nil {
+		b.users = b.users[:len(b.users)-1]
 		return errors.Wrap(err, "failed to initialise user")
 	}