yesBad/proton-bridge
1
0
Fork 0
Code Actions Activity

fix: don't log errors caused by empty SELECT

Browse Source
This commit is contained in:
James Houlahan
2021-01-14 14:00:41 +01:00
parent 014c8af560
commit c677b78f16
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/imap/user.go
View File

@ -136,7 +136,16 @@ func (iu *imapUser) GetMailbox(name string) (mb goIMAPBackend.Mailbox, err error
storeMailbox, err := iu.storeAddress.GetMailbox(name) storeMailbox, err := iu.storeAddress.GetMailbox(name)
if err != nil { if err != nil {
log.WithField("name", name).WithError(err).Error("Could not get mailbox") logMsg := log.WithField("name", name).WithError(err)
// GODT-97: some clients perform SELECT "" in order to unselect.
// We don't want to fill the logs with errors in this case.
if name != "" {
logMsg.Error("Could not get mailbox")
} else {
logMsg.Debug("Failed attempt to get mailbox with empty name")
}
return return
} }

1
unreleased.md
View File

@ -9,6 +9,7 @@ Changelog [format](http://keepachangelog.com/en/1.0.0/)
### Removed ### Removed
### Changed ### Changed
* GODT-97 Don't log errors caused by SELECT "".
### Fixed ### Fixed
* GODT-979 Fix panic when trying to parse a multipart/alternative section that has no child sections. * GODT-979 Fix panic when trying to parse a multipart/alternative section that has no child sections.