yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

Parsing message with empty address as '<>'

Browse Source
This commit is contained in:
Michal Horejsek
2020-09-24 15:37:21 +02:00
parent 15c1d7bc24
commit e02c7c7f06
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Changelog.md
View File

@ -5,7 +5,7 @@ Changelog [format](http://keepachangelog.com/en/1.0.0/)
## Unreleased ## Unreleased
### Fixed ### Fixed
* GODT-752 Parsing message with empty CC. * GODT-752 Parsing message with empty addresses.
* GODT-752 Parsing non-utf8 multipart/alternative message. * GODT-752 Parsing non-utf8 multipart/alternative message.
* GODT-752 Parsing message with duplicate charset parameter. * GODT-752 Parsing message with duplicate charset parameter.

2
pkg/message/header.go
View File

@ -152,7 +152,7 @@ func parseAddressComment(raw string) string {
} }
func parseAddressList(val string) (addrs []*mail.Address, err error) { func parseAddressList(val string) (addrs []*mail.Address, err error) {
if val == "" { if val == "" || val == "<>" {
return return
} }

4
pkg/message/parser_test.go
View File

@ -224,8 +224,8 @@ func TestParseTextPlainWithPlainAttachment(t *testing.T) {
assert.Equal(t, readerToString(attReaders[0]), "attachment") assert.Equal(t, readerToString(attReaders[0]), "attachment")
} }
func TestParseTextPlainEmptyCC(t *testing.T) { func TestParseTextPlainEmptyAddresses(t *testing.T) {
f := getFileReader("text_plain_empty_cc.eml") f := getFileReader("text_plain_empty_addresses.eml")
m, _, plainBody, attReaders, err := Parse(f, "", "") m, _, plainBody, attReaders, err := Parse(f, "", "")
require.NoError(t, err) require.NoError(t, err)

1
pkg/message/testdata/text_plain_empty_cc.eml → pkg/message/testdata/text_plain_empty_addresses.eml vendored
View File

@ -1,5 +1,6 @@
From: Sender <sender@pm.me> From: Sender <sender@pm.me>
To: Receiver <receiver@pm.me> To: Receiver <receiver@pm.me>
CC: CC:
Reply-To: <>
body body