forked from Silverfish/proton-bridge
fix(GODT-2390): Missing changes from pervious commit
Always reports error type to sentry. Add error checks for get event as well.
This commit is contained in:
@ -19,6 +19,7 @@ package bridge
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
|
||||||
"github.com/ProtonMail/gluon/reporter"
|
"github.com/ProtonMail/gluon/reporter"
|
||||||
@ -142,7 +143,7 @@ func (bridge *Bridge) handleUserDeauth(ctx context.Context, user *user.User) {
|
|||||||
func (bridge *Bridge) handleUserBadEvent(ctx context.Context, user *user.User, err error) {
|
func (bridge *Bridge) handleUserBadEvent(ctx context.Context, user *user.User, err error) {
|
||||||
safe.Lock(func() {
|
safe.Lock(func() {
|
||||||
if rerr := bridge.reporter.ReportMessageWithContext("Failed to handle event", reporter.Context{
|
if rerr := bridge.reporter.ReportMessageWithContext("Failed to handle event", reporter.Context{
|
||||||
"error_type": fmt.Sprintf("%T", err),
|
"error_type": fmt.Sprintf("%T", getUnwrappedError(err)),
|
||||||
"error": err,
|
"error": err,
|
||||||
}); rerr != nil {
|
}); rerr != nil {
|
||||||
logrus.WithError(rerr).Error("Failed to report failed event handling")
|
logrus.WithError(rerr).Error("Failed to report failed event handling")
|
||||||
@ -154,9 +155,22 @@ func (bridge *Bridge) handleUserBadEvent(ctx context.Context, user *user.User, e
|
|||||||
|
|
||||||
func (bridge *Bridge) handleUncategorizedErrorEvent(event events.UncategorizedEventError) {
|
func (bridge *Bridge) handleUncategorizedErrorEvent(event events.UncategorizedEventError) {
|
||||||
if rerr := bridge.reporter.ReportMessageWithContext("Failed to handle due to uncategorized error", reporter.Context{
|
if rerr := bridge.reporter.ReportMessageWithContext("Failed to handle due to uncategorized error", reporter.Context{
|
||||||
"error_type": fmt.Sprintf("%T", event.Error),
|
"error_type": fmt.Sprintf("%T", getUnwrappedError(event.Error)),
|
||||||
"error": event.Error,
|
"error": event.Error,
|
||||||
}); rerr != nil {
|
}); rerr != nil {
|
||||||
logrus.WithError(rerr).Error("Failed to report failed event handling")
|
logrus.WithError(rerr).Error("Failed to report failed event handling")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func getUnwrappedError(err error) error {
|
||||||
|
for {
|
||||||
|
unwrapped := errors.Unwrap(err)
|
||||||
|
if unwrapped == nil {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
|
||||||
|
err = unwrapped
|
||||||
|
}
|
||||||
|
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|||||||
@ -630,6 +630,33 @@ func (user *User) doEventPoll(ctx context.Context) error {
|
|||||||
|
|
||||||
event, err := user.client.GetEvent(ctx, user.vault.EventID())
|
event, err := user.client.GetEvent(ctx, user.vault.EventID())
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
if netErr := new(proton.NetError); errors.As(err, &netErr) {
|
||||||
|
return fmt.Errorf("failed to get event due to network issue: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Catch all for uncategorized net errors that may slip through.
|
||||||
|
if netErr := new(net.OpError); errors.As(err, &netErr) {
|
||||||
|
user.eventCh.Enqueue(events.UncategorizedEventError{
|
||||||
|
UserID: user.ID(),
|
||||||
|
Error: err,
|
||||||
|
})
|
||||||
|
|
||||||
|
return fmt.Errorf("failed to get event due to network issues (uncategorized): %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// In case a json decode error slips through.
|
||||||
|
if jsonErr := new(json.UnmarshalTypeError); errors.As(err, &jsonErr) {
|
||||||
|
user.eventCh.Enqueue(events.UncategorizedEventError{
|
||||||
|
UserID: user.ID(),
|
||||||
|
Error: err,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// If the error is a server-side issue, return error to retry later.
|
||||||
|
if apiErr := new(proton.APIError); errors.As(err, &apiErr) && apiErr.Status >= 500 {
|
||||||
|
return fmt.Errorf("failed to get event due to server error: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
return fmt.Errorf("failed to get event: %w", err)
|
return fmt.Errorf("failed to get event: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user