yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

storage_migrate: pull out snapshot decision

Browse Source 
into new top-level helper for re-use with remote migration.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
Fabian Grünbichler
2022-02-03 13:41:41 +01:00
committed by Thomas Lamprecht
parent f78f26ae60
commit 05b07a67f5
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
PVE/Storage.pm
View File

@ -643,6 +643,14 @@ my $volname_for_storage = sub {
} }
}; };
# whether a migration snapshot is needed for a given storage
sub storage_migrate_snapshot {
my ($cfg, $storeid) = @_;
my $scfg = storage_config($cfg, $storeid);
return $scfg->{type} eq 'zfspool' || $scfg->{type} eq 'btrfs';
}
sub storage_migrate { sub storage_migrate {
my ($cfg, $volid, $target_sshinfo, $target_storeid, $opts, $logfunc) = @_; my ($cfg, $volid, $target_sshinfo, $target_storeid, $opts, $logfunc) = @_;
@ -688,10 +696,8 @@ sub storage_migrate {
my $migration_snapshot; my $migration_snapshot;
if (!defined($snapshot)) { if (!defined($snapshot)) {
if ($scfg->{type} eq 'zfspool' || $scfg->{type} eq 'btrfs') { $migration_snapshot = storage_migrate_snapshot($cfg, $storeid);
$migration_snapshot = 1; $snapshot = '__migration__' if $migration_snapshot;
$snapshot = '__migration__';
}
} }
my @formats = volume_transfer_formats($cfg, $volid, $target_volid, $snapshot, $base_snapshot, $with_snapshots); my @formats = volume_transfer_formats($cfg, $volid, $target_volid, $snapshot, $base_snapshot, $with_snapshots);