yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perlcritic: avoid conditional variable declaration

Browse Source 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht
2020-11-23 15:13:33 +01:00
parent afeda18256
commit 1207620cf0
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
PVE/Diskmanage.pm
View File

@ -713,9 +713,12 @@ sub get_partnum {
sub get_blockdev { sub get_blockdev {
my ($part_path) = @_; my ($part_path) = @_;
my $dev = $1 if $part_path =~ m|^/dev/(.*)$|; my ($dev, $block_dev);
my $link = readlink "/sys/class/block/$dev"; if ($part_path =~ m|^/dev/(.*)$|) {
my $block_dev = $1 if $link =~ m|([^/]*)/$dev$|; $dev = $1;
my $link = readlink "/sys/class/block/$dev";
$block_dev = $1 if $link =~ m|([^/]*)/$dev$|;
}
die "Can't parse parent device\n" if !defined($block_dev); die "Can't parse parent device\n" if !defined($block_dev);
die "No valid block device\n" if index($dev, $block_dev) == -1; die "No valid block device\n" if index($dev, $block_dev) == -1;

3
PVE/Storage.pm
View File

@ -1411,7 +1411,8 @@ sub decompressor_info {
die "ERROR: archive format not defined\n" die "ERROR: archive format not defined\n"
if !defined($decompressor->{$format}); if !defined($decompressor->{$format});
my $decomp = $decompressor->{$format}->{$comp} if $comp; my $decomp;
$decomp = $decompressor->{$format}->{$comp} if $comp;
my $info = { my $info = {
format => $format, format => $format,