From 203d73baf9f73f4d0652135f7f6f0179317c0a97 Mon Sep 17 00:00:00 2001
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
Date: Fri, 8 Mar 2024 13:34:31 +0100
Subject: [PATCH] add a warnings array to import-metadata

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
---
 src/PVE/Storage/ESXiPlugin.pm | 28 ++++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index 1daaff8..64c4a6d 100644
--- a/src/PVE/Storage/ESXiPlugin.pm
+++ b/src/PVE/Storage/ESXiPlugin.pm
@@ -898,8 +898,13 @@ sub get_create_args {
     my $create_args = {};
     my $create_disks = {};
     my $create_net = {};
+    my $warnings = [];
     my $ignored_volumes = {};
 
+    my $warn = sub {
+	push @$warnings, { message => $_[0] };
+    };
+
     my ($cores, $sockets) = $self->cpu_info();
     $create_args->{cores} = $cores if $cores != 1;
     $create_args->{sockets} = $sockets if $sockets != 1;
@@ -990,17 +995,23 @@ sub get_create_args {
 	$boot_order .= $bus.$count;
     };
     $self->for_each_disk($add_disk);
-    for my $nvme (@nvmes) {
-	my ($slot, $file, $devtype, $kind) = @$nvme;
-	$add_disk->('nvme', $slot, $file, $devtype, $kind, 1);
+    if (@nvmes) {
+	$warn->("PVE currently does not support NVMe guest disks, they are converted to SCSI");
+	for my $nvme (@nvmes) {
+	    my ($slot, $file, $devtype, $kind) = @$nvme;
+	    $add_disk->('nvme', $slot, $file, $devtype, $kind, 1);
+	}
     }
 
     $scsihw //= $default_scsihw;
-    if ($firmware eq 'efi' && !defined($scsihw) || $scsihw =~ /^lsi/) {
-	if ($is_windows) {
-	    $scsihw = 'pvscsi';
-	} else {
-	    $scsihw = 'virtio-scsi-single';
+    if ($firmware eq 'efi') {
+	if (!defined($scsihw) || $scsihw =~ /^lsi/) {
+	    if ($is_windows) {
+		$scsihw = 'pvscsi';
+	    } else {
+		$scsihw = 'virtio-scsi-single';
+	    }
+	    $warn->("OVMF is built without LSI drivers, scsi hardware was set to $scsihw");
 	}
     }
     $create_args->{scsihw} = $scsihw;
@@ -1026,6 +1037,7 @@ sub get_create_args {
 	disks => $create_disks,
 	net => $create_net,
 	'ignored-volumes' => $ignored_volumes,
+	warnings => $warnings,
     };
 }