yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dir plugin: code cleanup

Browse Source 
mostly re-ordering to improve statement grouping and avoiding the
need for an intermediate variable

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht
2020-12-07 16:07:36 +01:00
parent a8e00d1a5d
commit 20471dfd95
1 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
PVE/Storage/DirPlugin.pm
View File

@ -89,32 +89,27 @@ sub parse_is_mountpoint {
sub get_volume_notes { sub get_volume_notes {
my ($class, $scfg, $storeid, $volname, $timeout) = @_; my ($class, $scfg, $storeid, $volname, $timeout) = @_;
my $path = $class->filesystem_path($scfg, $volname); my $path = $class->filesystem_path($scfg, $volname);
$path .= $class->SUPER::NOTES_EXT; $path .= $class->SUPER::NOTES_EXT;
my $notes = ""; return PVE::Tools::file_get_contents($path) if -f $path;
if (-f $path) { return '';
$notes = PVE::Tools::file_get_contents($path);
}
return $notes;
} }
sub update_volume_notes { sub update_volume_notes {
my ($class, $scfg, $storeid, $volname, $notes, $timeout) = @_; my ($class, $scfg, $storeid, $volname, $notes, $timeout) = @_;
my ($vtype) = $class->parse_volname($volname);
die "only backups can have notes\n" if $vtype ne 'backup';
my $path = $class->filesystem_path($scfg, $volname); my $path = $class->filesystem_path($scfg, $volname);
my ($vtype, undef, undef, undef, undef, undef, undef) = $class->parse_volname($volname);
if ($vtype ne 'backup') {
die "only backups can have notes\n";
}
$path .= $class->SUPER::NOTES_EXT; $path .= $class->SUPER::NOTES_EXT;
PVE::Tools::file_set_contents($path, $notes); PVE::Tools::file_set_contents($path, $notes);
return undef; return;
} }
sub status { sub status {