yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

replace volume_support_qemu_snapshot with volume_qemu_snapshot

Browse Source 
This also changes the return values, since their meanings are rather
weird from the storage point of view. For instance, "internal" meant
it is *not* the storage which does the snapshot, while "external"
meant a mixture of storage and qemu-server side actions. `undef` meant
the storage does it all...

┌────────────┬───────────┐
│ previous   │ new       │
├────────────┼───────────┤
│ "internal" │ "qemu"    │
│ "external" │ "mixed"   │
│ undef      │ "storage" │
└────────────┴───────────┘

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Wolfgang Bumiller
2025-07-16 15:16:24 +02:00
parent 3941068c25
commit 41c6e4bf7a
6 changed files with 37 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/PVE/Storage/DirPlugin.pm
View File

@ -315,14 +315,13 @@ sub get_import_metadata {
};
}
sub volume_support_qemu_snapshot {
sub volume_qemu_snapshot_method {
my ($class, $storeid, $scfg, $volname) = @_;
my $format = ($class->parse_volname($volname))[6];
return if $format ne 'qcow2';
return 'storage' if $format ne 'qcow2';
my $type = $scfg->{'external-snapshots'} ? 'external' : 'internal';
return $type;
return $scfg->{'external-snapshots'} ? 'mixed' : 'qemu';
}
1;