yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

replace volume_support_qemu_snapshot with volume_qemu_snapshot

Browse Source 
This also changes the return values, since their meanings are rather
weird from the storage point of view. For instance, "internal" meant
it is *not* the storage which does the snapshot, while "external"
meant a mixture of storage and qemu-server side actions. `undef` meant
the storage does it all...

┌────────────┬───────────┐
│ previous   │ new       │
├────────────┼───────────┤
│ "internal" │ "qemu"    │
│ "external" │ "mixed"   │
│ undef      │ "storage" │
└────────────┴───────────┘

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Wolfgang Bumiller
2025-07-16 15:16:24 +02:00
parent 3941068c25
commit 41c6e4bf7a
6 changed files with 37 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/PVE/Storage.pm
View File

@ -2370,7 +2370,7 @@ sub rename_snapshot {
);
}
sub volume_support_qemu_snapshot {
sub volume_qemu_snapshot_method {
my ($cfg, $volid) = @_;
my ($storeid, $volname) = parse_volume_id($volid, 1);
@ -2380,7 +2380,7 @@ sub volume_support_qemu_snapshot {
my $plugin = PVE::Storage::Plugin->lookup($scfg->{type});
return $plugin->volume_support_qemu_snapshot($storeid, $scfg, $volname);
return $plugin->volume_qemu_snapshot_method($storeid, $scfg, $volname);
}
return undef;
}