yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

migrate: insecure: untaint the received ip/port

Browse Source
This commit is contained in:
Wolfgang Bumiller
2017-06-06 10:04:03 +02:00
committed by Dietmar Maurer
parent 47cea19432
commit 488cf14d4f
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
PVE/Storage.pm
View File

@ -671,9 +671,8 @@ sub storage_migrate {
if ($insecure) { if ($insecure) {
my $pid = open(my $info, '-|', @$recv) my $pid = open(my $info, '-|', @$recv)
or die "receive command failed: $!\n"; or die "receive command failed: $!\n";
my $ip = <$info> // die "no tunnel IP received\n"; my ($ip) = <$info> =~ /^($PVE::Tools::IPRE)$/ or die "no tunnel IP received\n";
my $port = <$info> // die "no tunnel port received\n"; my ($port) = <$info> =~ /^(\d+)$/ or die "no tunnel port received\n";
chomp($ip, $port);
my $socket = IO::Socket::IP->new(PeerHost => $ip, PeerPort => $port, Type => SOCK_STREAM) my $socket = IO::Socket::IP->new(PeerHost => $ip, PeerPort => $port, Type => SOCK_STREAM)
or die "failed to connect to tunnel at $ip:$port\n"; or die "failed to connect to tunnel at $ip:$port\n";
run_command([$send, @cstream], output => '>&'.fileno($socket)); run_command([$send, @cstream], output => '>&'.fileno($socket));