From 559867f79be200615d1889f08c941df7683a85ab Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Wed, 5 Mar 2025 11:49:21 +0100 Subject: [PATCH] api: alloc: allow 'vmdk' for the 'format' option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The API endpoint will automatically detect the format from the extension for raw, qcow2 and vmdk, but it was not yet possible to specify the format explicitly via the parameter. This could be annoying/surprising to users. There also might be third-party plugins that want to use vmdk, but not require a suffix in the name. Add 'vmdk' as an allowed format to avoid these issues and for consistency by using the 'pve-storage-format' format. Signed-off-by: Fiona Ebner Acked-by: Fabian Grünbichler Reviewed-by: Fabian Grünbichler --- src/PVE/API2/Storage/Content.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/Storage/Content.pm b/src/PVE/API2/Storage/Content.pm index 3b73e90..03cc4a1 100644 --- a/src/PVE/API2/Storage/Content.pm +++ b/src/PVE/API2/Storage/Content.pm @@ -6,6 +6,7 @@ use warnings; use PVE::SafeSyslog; use PVE::Cluster; use PVE::Storage; +use PVE::Storage::Plugin; # for 'pve-storage-format' format use PVE::INotify; use PVE::Exception qw(raise_param_exc); use PVE::RPCEnvironment; @@ -179,7 +180,7 @@ __PACKAGE__->register_method ({ }, 'format' => { type => 'string', - enum => ['raw', 'qcow2', 'subvol'], + format => 'pve-storage-format', requires => 'size', optional => 1, },