yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix #1135: refactor wear level parsing

Browse Source 
refactored the wear level parsing into its
own function, where we can now define a
vendor <-> attribute id
mapping

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak
2016-10-05 10:57:10 +02:00
committed by Dietmar Maurer
parent dd902da78e
commit 6965a6701e
1 changed files with 41 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
PVE/Diskmanage.pm
View File

@ -284,6 +284,44 @@ sub get_sysdir_info {
return $data; return $data;
} }
sub get_wear_leveling_info {
my ($attributes, $model) = @_;
my $wearout;
my $vendormap = {
'kingston' => 231,
'samsung' => 177,
'intel' => 233,
'sandisk' => 233,
'default' => 233,
};
# find target attr id
my $attrid;
foreach my $vendor (keys $vendormap) {
if ($model =~ m/$vendor/i) {
$attrid = $vendormap->{$vendor};
# found the attribute
last;
}
}
if (!$attrid) {
$attrid = $vendormap->{default};
}
foreach my $attr (@$attributes) {
next if $attr->{id} != $attrid;
$wearout = $attr->{value};
last;
}
return $wearout;
}
sub get_disks { sub get_disks {
my ($disk, $nosmart) = @_; my ($disk, $nosmart) = @_;
my $disklist = {}; my $disklist = {};
@ -366,7 +404,7 @@ sub get_disks {
} }
my $health = 'UNKNOWN'; my $health = 'UNKNOWN';
my $wearout; my $wearout = 'N/A';
if (!$nosmart) { if (!$nosmart) {
eval { eval {
@ -375,17 +413,8 @@ sub get_disks {
if ($type eq 'ssd') { if ($type eq 'ssd') {
# if we have an ssd we try to get the wearout indicator # if we have an ssd we try to get the wearout indicator
$wearout = 'N/A'; my $wearval = get_wear_leveling_info($smartdata->{attributes}, $sysdata->{model});
foreach my $attr (@{$smartdata->{attributes}}) { $wearout = $wearval if $wearval;
# ID 233 is media wearout indicator on intel and sandisk
# ID 177 is media wearout indicator on samsung
next if ($attr->{id} != 233 && $attr->{id} != 177);
next if ($attr->{name} !~ m/wear/i);
$wearout = $attr->{value};
# prefer the 233 value
last if ($attr->{id} == 233);
}
} }
}; };
} }