From 69a093c7fde825452ded960f3e8b004d963e6079 Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Mon, 18 May 2015 14:15:35 +0200 Subject: [PATCH] drbd: avoid warning about undefined value --- PVE/Storage/DRBDPlugin.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/Storage/DRBDPlugin.pm b/PVE/Storage/DRBDPlugin.pm index 61e0eb7..0179ad8 100644 --- a/PVE/Storage/DRBDPlugin.pm +++ b/PVE/Storage/DRBDPlugin.pm @@ -157,14 +157,14 @@ sub alloc_image { die "unsupported format '$fmt'" if $fmt ne 'raw'; die "illegal name '$name' - should be 'vm-$vmid-*'\n" - if $name && $name !~ m/^vm-$vmid-/; + if defined($name) && $name !~ m/^vm-$vmid-/; my $hdl = connect_drbdmanage_service(); my $volumes = drbd_list_volumes($hdl); - die "volume '$name' already exists\n" if $volumes->{$name}; + die "volume '$name' already exists\n" if defined($name) && $volumes->{$name}; - if (!$name) { + if (!defined($name)) { for (my $i = 1; $i < 100; $i++) { my $tn = "vm-$vmid-disk-$i"; if (!defined ($volumes->{$tn})) { @@ -175,7 +175,7 @@ sub alloc_image { } die "unable to allocate an image name for VM $vmid in storage '$storeid'\n" - if !$name; + if !defined($name); my ($rc, $res) = $hdl->create_resource($name, {}); check_drbd_rc($rc->[0]);