From 73bfe226d6c42a2fb45741e5fc68156d5d98cbe4 Mon Sep 17 00:00:00 2001 From: Alexandre Derumier Date: Wed, 9 Jul 2025 18:21:55 +0200 Subject: [PATCH] rbd && zfs : create_base : remove $running param from volume_snapshot template guests are never running and never write to their disks/mountpoints, those $running parameters there can be dropped. Signed-off-by: Alexandre Derumier --- src/PVE/Storage/RBDPlugin.pm | 4 +--- src/PVE/Storage/ZFSPlugin.pm | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm index f8199a9..988840f 100644 --- a/src/PVE/Storage/RBDPlugin.pm +++ b/src/PVE/Storage/RBDPlugin.pm @@ -630,9 +630,7 @@ sub create_base { eval { $class->unmap_volume($storeid, $scfg, $volname); }; warn $@ if $@; - my $running = undef; #fixme : is create_base always offline ? - - $class->volume_snapshot($scfg, $storeid, $newname, $snap, $running); + $class->volume_snapshot($scfg, $storeid, $newname, $snap); my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $newname, $snap); diff --git a/src/PVE/Storage/ZFSPlugin.pm b/src/PVE/Storage/ZFSPlugin.pm index 35eba59..cdec5ce 100644 --- a/src/PVE/Storage/ZFSPlugin.pm +++ b/src/PVE/Storage/ZFSPlugin.pm @@ -335,9 +335,7 @@ sub create_base { my $guid = $class->zfs_create_lu($scfg, $newname); $class->zfs_add_lun_mapping_entry($scfg, $newname, $guid); - my $running = undef; #fixme : is create_base always offline ? - - $class->volume_snapshot($scfg, $storeid, $newname, $snap, $running); + $class->volume_snapshot($scfg, $storeid, $newname, $snap); return $newvolname; }