From 7c62215e48f641f72dda1cc4d21dc609a5986603 Mon Sep 17 00:00:00 2001 From: Friedrich Weber Date: Wed, 26 Mar 2025 11:51:07 +0100 Subject: [PATCH] fix #3716: api: download from url: use proxy option for https The web UI uses the download-url endpoint for downloading an ISO, VZ template, or OVA file via wget. In a setup where this request has to go over a proxy (configured in the http_proxy datacenter option), the download only works for http:// URLs, not https:// URLs. The reason is that the download-url handler does not pass the https_proxy option to the download_file_from_url helper, hence the helper only sets the http_proxy environment variable for wget, not the https_proxy one. Fix this by also passing the https_proxy option to the download_file_from_url helper. This will break setups that rely on http_proxy not being respected for https:// URLs. For example, setups that have a proxy for external connections, but download e.g. ISO files (only) via https from an internal repository that the proxy doesn't serve. Signed-off-by: Friedrich Weber Reviewed-by: Maximiliano Sandoval Tested-by: Maximiliano Sandoval Link: https://lore.kernel.org/r/20250326105108.34911-2-f.weber@proxmox.com --- src/PVE/API2/Storage/Status.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm index c854b53..28362ca 100644 --- a/src/PVE/API2/Storage/Status.pm +++ b/src/PVE/API2/Storage/Status.pm @@ -700,6 +700,7 @@ __PACKAGE__->register_method({ hash_required => 0, verify_certificates => $param->{'verify-certificates'} // 1, http_proxy => $dccfg->{http_proxy}, + https_proxy => $dccfg->{http_proxy}, }; my ($checksum, $checksum_algorithm) = $param->@{'checksum', 'checksum-algorithm'};