From 8a183b5db2d8ebb0038a5dab84fb0ba66f452264 Mon Sep 17 00:00:00 2001 From: Shannon Sterz Date: Wed, 12 Mar 2025 09:38:19 +0100 Subject: [PATCH] disk management: account for leading white space in serial number some manufacturer seem to report leading white space in the `ID_SERIAL_SHORT` field. the regex failed here, as it just didn't match the whitespace at all. reported on the forum: https://forum.proxmox.com/threads/nvme-drive-serial-unknown.163480/#post-754953 Signed-off-by: Shannon Sterz Link: https://lore.proxmox.com/20250312083819.15379-1-s.sterz@proxmox.com --- src/PVE/Diskmanage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Diskmanage.pm b/src/PVE/Diskmanage.pm index 0217c75..4272668 100644 --- a/src/PVE/Diskmanage.pm +++ b/src/PVE/Diskmanage.pm @@ -328,7 +328,7 @@ sub get_udev_info { return if !defined($data->{devpath}); $data->{serial} = 'unknown'; - $data->{serial} = $1 if $info =~ m/^E: ID_SERIAL_SHORT=(\S+)$/m; + $data->{serial} = $1 if $info =~ m/^E: ID_SERIAL_SHORT=\s*(\S+)$/m; $data->{gpt} = $info =~ m/^E: ID_PART_TABLE_TYPE=gpt$/m ? 1 : 0;