yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

do not automatically die on smartctl exit code > 0

Browse Source 
since smartctl uses the return value to encode
disk health status (such as failure in the past)
we cannot die there, but have to parse the returncode

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak
2016-09-08 14:27:12 +02:00
committed by Dietmar Maurer
parent 16171cedec
commit 9018a4e639
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
PVE/Diskmanage.pm
View File

@ -76,8 +76,9 @@ sub get_smart_data {
my $smartdata = {}; my $smartdata = {};
my $datastarted = 0; my $datastarted = 0;
my $returncode = 0;
eval { eval {
run_command([$SMARTCTL, '-a', '-f', 'brief', $disk], outfunc => sub{ $returncode = run_command([$SMARTCTL, '-a', '-f', 'brief', $disk], noerr => 1, outfunc => sub{
my ($line) = @_; my ($line) = @_;
if ($datastarted && $line =~ m/^[ \d]{2}\d/) { if ($datastarted && $line =~ m/^[ \d]{2}\d/) {
@ -101,7 +102,14 @@ sub get_smart_data {
} }
}); });
}; };
die "Error getting S.M.A.R.T. data: $@\n" if $@; my $err = $@;
# bit 0 and 1 mark an severe smartctl error
# all others are for disk status, so ignore them
# see smartctl(8)
if ((defined($returncode) && ($returncode & 0b00000011)) || $err) {
die "Error getting S.M.A.R.T. data: Exit code: $returncode\n";
}
$smartdata->{health} = 'UNKOWN' if !defined $smartdata->{health}; $smartdata->{health} = 'UNKOWN' if !defined $smartdata->{health};
return $smartdata; return $smartdata;
} }
@ -114,7 +122,7 @@ sub get_smart_health {
my $message = "UNKOWN"; my $message = "UNKOWN";
eval { eval {
run_command([$SMARTCTL, '-H', $disk], outfunc => sub { run_command([$SMARTCTL, '-H', $disk], noerr => 1, outfunc => sub {
my ($line) = @_; my ($line) = @_;
if ($line =~ m/test result: (.*)$/) { if ($line =~ m/test result: (.*)$/) {