yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

export: redirect stdout to avoid any unrelated messages ending up in the export stream

Browse Source 
Current export implementations luckily seems to not run into this
issue yet. However, for the upcoming implementation for RBD, mapping a
volume would print the device path to STDOUT, thus messing up the
export stream.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner
2024-12-19 11:43:06 +01:00
committed by Fabian Grünbichler
parent 7166db2ce4
commit 9adc4c69ef
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/PVE/CLI/pvesm.pm
View File

@ -315,7 +315,10 @@ __PACKAGE__->register_method ({
my $outfh; my $outfh;
if ($filename eq '-') { if ($filename eq '-') {
$outfh = \*STDOUT; # No other messages must go to STDOUT if it's used for the export stream!
open($outfh, '>&', STDOUT) or die "unable to dup() STDOUT - $!\n";
close(STDOUT);
open(STDOUT, '>', '/dev/null');
} else { } else {
sysopen($outfh, $filename, O_CREAT|O_WRONLY|O_TRUNC) sysopen($outfh, $filename, O_CREAT|O_WRONLY|O_TRUNC)
or die "open($filename): $!\n"; or die "open($filename): $!\n";