From a7afad969d1e60afa3f7f3f430a4fd2c0b1d1bf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Tue, 29 Jul 2025 13:53:16 +0200 Subject: [PATCH] plugin: fix typo in rebase log message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit by directly printing the to-be-executed command, instead of copying it which is error-prone. Signed-off-by: Fabian Grünbichler Reviewed-by: Fiona Ebner Link: https://lore.proxmox.com/20250729115320.579286-2-f.gruenbichler@proxmox.com [FE: use string concatenation rather than multi-argument print] Signed-off-by: Fiona Ebner --- src/PVE/Storage/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 2bd05bd..0b3b64a 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1437,7 +1437,6 @@ sub volume_snapshot_delete { my $parentpath = $snapshots->{$parentsnap}->{file}; print "$volname: deleting snapshot '$snap' by rebasing '$childsnap' on top of '$parentsnap'\n"; - print "running 'qemu-img rebase -b $parentpath -F qcow -f qcow2 $childpath'\n"; $cmd = [ '/usr/bin/qemu-img', 'rebase', @@ -1449,6 +1448,7 @@ sub volume_snapshot_delete { 'qcow2', $childpath, ]; + print "running '" . join(' ', $cmd->@*) . "'\n"; eval { run_command($cmd) }; if ($@) { #in case of abort, the state of the snap is still clean, just a little bit bigger