From ae93163343ca75ca2aa0ac2d436669872feb2825 Mon Sep 17 00:00:00 2001 From: Stoiko Ivanov Date: Tue, 3 May 2022 13:31:40 +0200 Subject: [PATCH] rbd: warn if no stats for a pool could be gathered happens in case of a mistyped poolname, and the new message should be more helpful than: `Use of uninitialized value $free in addition (+) at \ /usr/share/perl5/PVE/Storage/RBDPlugin.pm line 64` Signed-off-by: Stoiko Ivanov --- PVE/Storage/RBDPlugin.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 9ee6a37..fb48c3f 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -634,6 +634,11 @@ sub status { my ($d) = grep { $_->{name} eq $pool } @{$df->{pools}}; + if (!defined($d)) { + warn "could not get usage stats for pool '$pool'\n"; + return; + } + # max_avail -> max available space for data w/o replication in the pool # bytes_used -> data w/o replication in the pool my $free = $d->{stats}->{max_avail};