From b3c844b858cb5e7289a9d4ef9f619c9dfd421d3e Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Thu, 19 Dec 2024 11:43:14 +0100 Subject: [PATCH] rbd plugin: list: drop outdated error message check This became outdated after Ceph commit ac547a5b7dc ("rbd: return 0 and an empty list when pool is entirely empty") 11 years ago. See also: https://tracker.ceph.com/issues/6693 Signed-off-by: Fiona Ebner --- src/PVE/Storage/RBDPlugin.pm | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm index a362529..ef4faa6 100644 --- a/src/PVE/Storage/RBDPlugin.pm +++ b/src/PVE/Storage/RBDPlugin.pm @@ -216,12 +216,7 @@ sub rbd_ls { my $parser = sub { $raw .= shift }; my $cmd = $rbd_cmd->($scfg, $storeid, 'ls', '-l', '--format', 'json'); - eval { - run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser); - }; - my $err = $@; - - die $err if $err && $err !~ m/doesn't contain rbd images/ ; + run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser); my $result; if ($raw eq '') {